third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h - Issue 2751163002: Report UseCounter metric when observing NotDef glyphs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h

Issue 2751163002: Report UseCounter metric when observing NotDef glyphs (Closed)

Patch Set: Relax num_glyphs assertion, not feasible on Mac Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h

index dd7c39c1dd88b6eb854641530171ac3a63311e57..126d25004ffd2cd0f626822bf41d822f0d8e3afa 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h

+++ b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h

@@ -80,7 +80,7 @@ class PLATFORM_EXPORT HarfBuzzShaper final {

RunSegmenter::RunSegmenterRange,

ShapeResult*) const;

- bool ExtractShapeResults(RangeData*,

+ void ExtractShapeResults(RangeData*,

bool& font_cycle_queued,

const HolesQueueItem&,

const SimpleFontData*,