Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSFontSelector.cpp

Issue 2751163002: Report UseCounter metric when observing NotDef glyphs (Closed)
Patch Set: Relax num_glyphs assertion, not feasible on Mac Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2011 Apple Inc. All rights reserved.
3 * (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org> 3 * (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 16 matching lines...) Expand all
27 #include "core/css/CSSFontSelector.h" 27 #include "core/css/CSSFontSelector.h"
28 28
29 #include "core/css/CSSFontSelectorClient.h" 29 #include "core/css/CSSFontSelectorClient.h"
30 #include "core/css/CSSSegmentedFontFace.h" 30 #include "core/css/CSSSegmentedFontFace.h"
31 #include "core/css/CSSValueList.h" 31 #include "core/css/CSSValueList.h"
32 #include "core/css/FontFaceSet.h" 32 #include "core/css/FontFaceSet.h"
33 #include "core/css/resolver/StyleResolver.h" 33 #include "core/css/resolver/StyleResolver.h"
34 #include "core/dom/Document.h" 34 #include "core/dom/Document.h"
35 #include "core/frame/LocalFrame.h" 35 #include "core/frame/LocalFrame.h"
36 #include "core/frame/Settings.h" 36 #include "core/frame/Settings.h"
37 #include "core/frame/UseCounter.h"
37 #include "core/loader/FrameLoader.h" 38 #include "core/loader/FrameLoader.h"
38 #include "platform/RuntimeEnabledFeatures.h" 39 #include "platform/RuntimeEnabledFeatures.h"
39 #include "platform/fonts/FontCache.h" 40 #include "platform/fonts/FontCache.h"
40 #include "platform/fonts/SimpleFontData.h" 41 #include "platform/fonts/SimpleFontData.h"
41 #include "platform/wtf/text/AtomicString.h" 42 #include "platform/wtf/text/AtomicString.h"
42 43
43 namespace blink { 44 namespace blink {
44 45
45 CSSFontSelector::CSSFontSelector(Document* document) 46 CSSFontSelector::CSSFontSelector(Document* document)
46 : document_(document), 47 : document_(document),
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 } 167 }
167 168
168 void CSSFontSelector::UpdateGenericFontFamilySettings(Document& document) { 169 void CSSFontSelector::UpdateGenericFontFamilySettings(Document& document) {
169 if (!document.GetSettings()) 170 if (!document.GetSettings())
170 return; 171 return;
171 generic_font_family_settings_ = 172 generic_font_family_settings_ =
172 document.GetSettings()->GetGenericFontFamilySettings(); 173 document.GetSettings()->GetGenericFontFamilySettings();
173 FontCacheInvalidated(); 174 FontCacheInvalidated();
174 } 175 }
175 176
177 void CSSFontSelector::ReportNotDefGlyph() const {
178 DCHECK(document_);
179 UseCounter::Count(document_, UseCounter::kFontShapingNotDefGlyphObserved);
180 }
181
176 DEFINE_TRACE(CSSFontSelector) { 182 DEFINE_TRACE(CSSFontSelector) {
177 visitor->Trace(document_); 183 visitor->Trace(document_);
178 visitor->Trace(font_face_cache_); 184 visitor->Trace(font_face_cache_);
179 visitor->Trace(clients_); 185 visitor->Trace(clients_);
180 FontSelector::Trace(visitor); 186 FontSelector::Trace(visitor);
181 } 187 }
182 188
183 } // namespace blink 189 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSFontSelector.h ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698