Move ui/gfx/codec/ into its own component.

Move ui/gfx/codec/ into its own component.

This is necessary to break an include cycle between cc and ui/gfx/ for upcoming
changes to cc/paint/.

TBR=robertphillips@google.com

BUG=665259
Review-Url: https://codereview.chromium.org/2755563002
Cr-Commit-Position: refs/heads/master@{#457238}
Committed: https://chromium.googlesource.com/chromium/src/+/e3d8f58563aececeeaa395795e022ddadf23c93d

[chrishtr, 2017-03-14 23:41:00]

Description was changed from

==========
none


none


none


none


Merge branch 'finalgn15' into finalgn18


none


none

BUG=
==========

to

==========
Move ui/gfx/codec/ into its own component.

BUG=
==========

[chrishtr, 2017-03-14 23:41:05]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 23:41:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 23:47:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 23:47:56]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[chrishtr, 2017-03-15 14:21:02]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[chrishtr, 2017-03-15 14:21:13]

Description was changed from

==========
Move ui/gfx/codec/ into its own component.

BUG=
==========

to

==========
Move ui/gfx/codec/ into its own component.

BUG=665259
==========

[commit-bot: I haz the power, 2017-03-15 14:21:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 14:32:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 14:32:52]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2017-03-15 16:53:23]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 16:53:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-03-15 16:53:47]

Description was changed from

==========
Move ui/gfx/codec/ into its own component.

BUG=665259
==========

to

==========
Move ui/gfx/codec/ into its own component.

This is necessary to break an include cycle between cc and ui/gfx/ for upcoming
changes to cc/paint/.

BUG=665259
==========

[chrishtr, 2017-03-15 16:53:52]

chrishtr@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2017-03-15 17:48:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 17:48:28]

Dry run: This issue passed the CQ dry run.

[sky, 2017-03-15 19:27:41]

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/BUILD.gn
File ui/gfx/BUILD.gn (left):

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/BUILD.gn#oldcode361
ui/gfx/BUILD.gn:361: cflags = [ "/wd4324" ]  # Structure was padded due to
__declspec(align()), which is
Is this needed in both files?

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/BUILD.gn
File ui/gfx/codec/BUILD.gn (right):

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/BUILD.gn#n...
ui/gfx/codec/BUILD.gn:4: ##      "//cc/paint",
Remove this line?

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/BUILD.gn#n...
ui/gfx/codec/BUILD.gn:40: "../chromeos/codec/jpeg_codec_robust_slow.cc",
Please move these files into this directory.

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/codec_expo...
File ui/gfx/codec/codec_export.h (right):

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/codec_expo...
ui/gfx/codec/codec_export.h:1: // Copyright 2016 The Chromium Authors. All
rights reserved.
2017

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/skia_image...
File ui/gfx/codec/skia_image_encoder_adapter.h (right):

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/skia_image...
ui/gfx/codec/skia_image_encoder_adapter.h:13: #include
"ui/gfx/codec/codec_export.h"
Move include with other includes.

[chrishtr, 2017-03-15 19:52:17]

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/BUILD.gn
File ui/gfx/BUILD.gn (left):

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/BUILD.gn#oldcode361
ui/gfx/BUILD.gn:361: cflags = [ "/wd4324" ]  # Structure was padded due to
__declspec(align()), which is
On 2017/03/15 at 19:27:41, sky wrote:
> Is this needed in both files?

Not sure. Removed, will re-add if it causes a compile fail.

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/BUILD.gn
File ui/gfx/codec/BUILD.gn (right):

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/BUILD.gn#n...
ui/gfx/codec/BUILD.gn:4: ##      "//cc/paint",
On 2017/03/15 at 19:27:41, sky wrote:
> Remove this line?

Done.

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/codec_expo...
File ui/gfx/codec/codec_export.h (right):

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/codec_expo...
ui/gfx/codec/codec_export.h:1: // Copyright 2016 The Chromium Authors. All
rights reserved.
On 2017/03/15 at 19:27:41, sky wrote:
> 2017

Done, sorry about that.

[chrishtr, 2017-03-15 19:52:26]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 19:52:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-03-15 19:56:42]

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/BUILD.gn
File ui/gfx/codec/BUILD.gn (right):

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/BUILD.gn#n...
ui/gfx/codec/BUILD.gn:40: "../chromeos/codec/jpeg_codec_robust_slow.cc",
On 2017/03/15 19:27:41, sky wrote:
> Please move these files into this directory.

Did you see this comment?

[chrishtr, 2017-03-15 20:00:00]

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/BUILD.gn
File ui/gfx/codec/BUILD.gn (right):

https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/BUILD.gn#n...
ui/gfx/codec/BUILD.gn:40: "../chromeos/codec/jpeg_codec_robust_slow.cc",
On 2017/03/15 at 19:27:41, sky wrote:
> Please move these files into this directory.

Sorry saw this two minutes ago. Done.

[chrishtr, 2017-03-15 20:00:50]

chrishtr@chromium.org changed reviewers:
+ robertphillips@google.com

[chrishtr, 2017-03-15 20:00:50]

+robertphillips for Skia approval.

[chrishtr, 2017-03-15 20:00:55]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 20:01:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 20:07:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 20:08:00]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2017-03-15 20:15:01]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 20:15:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 20:24:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 20:24:08]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-03-15 20:27:35]

LGTM

https://codereview.chromium.org/2755563002/diff/100001/ui/gfx/codec/chromeos/...
File ui/gfx/codec/chromeos/jpeg_codec_robust_slow.cc (right):

https://codereview.chromium.org/2755563002/diff/100001/ui/gfx/codec/chromeos/...
ui/gfx/codec/chromeos/jpeg_codec_robust_slow.cc:18: #include
"third_party/skia/include/core/SkBitmap.h"
Is there a reason these need to be moved down?

[chrishtr, 2017-03-15 20:28:20]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[chrishtr, 2017-03-15 20:29:00]

https://codereview.chromium.org/2755563002/diff/100001/ui/gfx/codec/chromeos/...
File ui/gfx/codec/chromeos/jpeg_codec_robust_slow.cc (right):

https://codereview.chromium.org/2755563002/diff/100001/ui/gfx/codec/chromeos/...
ui/gfx/codec/chromeos/jpeg_codec_robust_slow.cc:18: #include
"third_party/skia/include/core/SkBitmap.h"
On 2017/03/15 at 20:27:34, sky wrote:
> Is there a reason these need to be moved down?

Yes - the presubmit check complained about the include of
third_party/libjpeg/jpeglib.h being at the wrong place.

[commit-bot: I haz the power, 2017-03-15 20:29:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-03-15 20:31:05]

+rockot for change to services/image/decoder/

[chrishtr, 2017-03-15 20:31:14]

chrishtr@chromium.org changed reviewers:
+ rockot@chromium.org

[commit-bot: I haz the power, 2017-03-15 21:38:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 21:38:53]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2017-03-15 22:18:49]

lgtm

[chrishtr, 2017-03-15 22:20:41]

Description was changed from

==========
Move ui/gfx/codec/ into its own component.

This is necessary to break an include cycle between cc and ui/gfx/ for upcoming
changes to cc/paint/.

BUG=665259
==========

to

==========
Move ui/gfx/codec/ into its own component.

This is necessary to break an include cycle between cc and ui/gfx/ for upcoming
changes to cc/paint/.

TBR=robertphillips@google.com

BUG=665259
==========

[chrishtr, 2017-03-15 22:20:42]

chrishtr@chromium.org changed reviewers:
- robertphillips@google.com

[chrishtr, 2017-03-15 22:20:45]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-15 22:20:45]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2755563002/#ps120001
(title: "none")

[commit-bot: I haz the power, 2017-03-15 22:21:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 22:30:20]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1489616445329630,
"parent_rev": "231cffae9f80aa63ef0d77ac2775b0a2268978a4", "commit_rev":
"e3d8f58563aececeeaa395795e022ddadf23c93d"}

[commit-bot: I haz the power, 2017-03-15 22:31:03]

Description was changed from

==========
Move ui/gfx/codec/ into its own component.

This is necessary to break an include cycle between cc and ui/gfx/ for upcoming
changes to cc/paint/.

TBR=robertphillips@google.com

BUG=665259
==========

to

==========
Move ui/gfx/codec/ into its own component.

This is necessary to break an include cycle between cc and ui/gfx/ for upcoming
changes to cc/paint/.

TBR=robertphillips@google.com

BUG=665259

Review-Url: https://codereview.chromium.org/2755563002
Cr-Commit-Position: refs/heads/master@{#457238}
Committed:
https://chromium.googlesource.com/chromium/src/+/e3d8f58563aececeeaa395795e02...
==========

[commit-bot: I haz the power, 2017-03-15 22:31:04]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/e3d8f58563aececeeaa395795e02...

[findit-for-me, 2017-03-15 22:59:24]

FYI: Findit identified this CL at revision 457238 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[chrishtr, 2017-03-15 23:08:04]

looking...

On Wed, Mar 15, 2017 at 3:59 PM, findit-for-me@appspot.gserviceaccount.com
via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com>
wrote:

>
> FYI: Findit identified this CL at revision 457238 as the culprit for
> failures in the build cycles as shown on:
> https://findit-for-me.appspot.com/waterfall/culprit?key=
> ag9zfmZpbmRpdC1mb3ItbWVyQAsSCVdmQ3VscHJpdCIxY2hyb21pdW0vZTNk
> OGY1ODU2M2FlY2VjZWVhYTM5NTc5NWUwMjJkZGFkZjIzYzkzZAw
>
> https://codereview.chromium.org/2755563002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chrishtr, 2017-03-15 23:10:57]

Found a fix, it's trivial. Please don't revert.

[chrishtr, 2017-03-15 23:12:13]

https://codereview.chromium.org/2746153007

[chrishtr, 2017-03-16 00:17:56]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2751103004/ by chrishtr@chromium.org.

The reason for reverting is: Breaks a chromeos unittest..