Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2755563002: Move ui/gfx/codec/ into its own component. (Closed)

Created:
3 years, 9 months ago by chrishtr
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ui/gfx/codec/ into its own component. This is necessary to break an include cycle between cc and ui/gfx/ for upcoming changes to cc/paint/. TBR=robertphillips@google.com BUG=665259 Review-Url: https://codereview.chromium.org/2755563002 Cr-Commit-Position: refs/heads/master@{#457238} Committed: https://chromium.googlesource.com/chromium/src/+/e3d8f58563aececeeaa395795e022ddadf23c93d

Patch Set 1 #

Patch Set 2 : Merge branch 'finalgn15' into finalgn18 #

Patch Set 3 : none #

Total comments: 10

Patch Set 4 : none #

Patch Set 5 : none #

Patch Set 6 : none #

Total comments: 2

Patch Set 7 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -581 lines) Patch
M services/image_decoder/image_decoder_impl.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 1 2 3 4 5 7 chunks +2 lines, -26 lines 0 comments Download
D ui/gfx/chromeos/codec/DEPS View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
D ui/gfx/chromeos/codec/OWNERS View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
D ui/gfx/chromeos/codec/jpeg_codec_robust_slow.h View 1 2 3 4 1 chunk +0 lines, -56 lines 0 comments Download
D ui/gfx/chromeos/codec/jpeg_codec_robust_slow.cc View 1 2 3 4 1 chunk +0 lines, -343 lines 0 comments Download
D ui/gfx/chromeos/codec/jpeg_codec_robust_slow_unittest.cc View 1 2 3 4 1 chunk +0 lines, -108 lines 0 comments Download
A ui/gfx/codec/BUILD.gn View 1 2 3 4 1 chunk +51 lines, -0 lines 0 comments Download
A + ui/gfx/codec/chromeos/DEPS View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/codec/chromeos/OWNERS View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/codec/chromeos/jpeg_codec_robust_slow.h View 1 2 3 4 3 chunks +9 lines, -6 lines 0 comments Download
A + ui/gfx/codec/chromeos/jpeg_codec_robust_slow.cc View 1 2 3 4 7 chunks +15 lines, -17 lines 0 comments Download
A + ui/gfx/codec/chromeos/jpeg_codec_robust_slow_unittest.cc View 1 2 3 4 5 6 2 chunks +7 lines, -11 lines 0 comments Download
A ui/gfx/codec/codec_export.h View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
M ui/gfx/codec/jpeg_codec.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/codec/png_codec.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/codec/skia_image_encoder_adapter.h View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 56 (38 generated)
chrishtr
3 years, 9 months ago (2017-03-15 16:53:53 UTC) #15
sky
https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/BUILD.gn File ui/gfx/BUILD.gn (left): https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/BUILD.gn#oldcode361 ui/gfx/BUILD.gn:361: cflags = [ "/wd4324" ] # Structure was padded ...
3 years, 9 months ago (2017-03-15 19:27:41 UTC) #18
chrishtr
https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/BUILD.gn File ui/gfx/BUILD.gn (left): https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/BUILD.gn#oldcode361 ui/gfx/BUILD.gn:361: cflags = [ "/wd4324" ] # Structure was padded ...
3 years, 9 months ago (2017-03-15 19:52:17 UTC) #19
sky
https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/BUILD.gn File ui/gfx/codec/BUILD.gn (right): https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/BUILD.gn#newcode40 ui/gfx/codec/BUILD.gn:40: "../chromeos/codec/jpeg_codec_robust_slow.cc", On 2017/03/15 19:27:41, sky wrote: > Please move ...
3 years, 9 months ago (2017-03-15 19:56:42 UTC) #22
chrishtr
https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/BUILD.gn File ui/gfx/codec/BUILD.gn (right): https://codereview.chromium.org/2755563002/diff/40001/ui/gfx/codec/BUILD.gn#newcode40 ui/gfx/codec/BUILD.gn:40: "../chromeos/codec/jpeg_codec_robust_slow.cc", On 2017/03/15 at 19:27:41, sky wrote: > Please ...
3 years, 9 months ago (2017-03-15 20:00:00 UTC) #23
chrishtr
+robertphillips for Skia approval.
3 years, 9 months ago (2017-03-15 20:00:50 UTC) #25
sky
LGTM https://codereview.chromium.org/2755563002/diff/100001/ui/gfx/codec/chromeos/jpeg_codec_robust_slow.cc File ui/gfx/codec/chromeos/jpeg_codec_robust_slow.cc (right): https://codereview.chromium.org/2755563002/diff/100001/ui/gfx/codec/chromeos/jpeg_codec_robust_slow.cc#newcode18 ui/gfx/codec/chromeos/jpeg_codec_robust_slow.cc:18: #include "third_party/skia/include/core/SkBitmap.h" Is there a reason these need ...
3 years, 9 months ago (2017-03-15 20:27:35 UTC) #34
chrishtr
https://codereview.chromium.org/2755563002/diff/100001/ui/gfx/codec/chromeos/jpeg_codec_robust_slow.cc File ui/gfx/codec/chromeos/jpeg_codec_robust_slow.cc (right): https://codereview.chromium.org/2755563002/diff/100001/ui/gfx/codec/chromeos/jpeg_codec_robust_slow.cc#newcode18 ui/gfx/codec/chromeos/jpeg_codec_robust_slow.cc:18: #include "third_party/skia/include/core/SkBitmap.h" On 2017/03/15 at 20:27:34, sky wrote: > ...
3 years, 9 months ago (2017-03-15 20:29:00 UTC) #36
chrishtr
+rockot for change to services/image/decoder/
3 years, 9 months ago (2017-03-15 20:31:05 UTC) #38
chrishtr
3 years, 9 months ago (2017-03-15 20:31:15 UTC) #40
Ken Rockot(use gerrit already)
lgtm
3 years, 9 months ago (2017-03-15 22:18:49 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755563002/120001
3 years, 9 months ago (2017-03-15 22:21:10 UTC) #48
commit-bot: I haz the power
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/e3d8f58563aececeeaa395795e022ddadf23c93d
3 years, 9 months ago (2017-03-15 22:31:04 UTC) #51
findit-for-me
FYI: Findit identified this CL at revision 457238 as the culprit for failures in the ...
3 years, 9 months ago (2017-03-15 22:59:24 UTC) #52
chrishtr
looking... On Wed, Mar 15, 2017 at 3:59 PM, findit-for-me@appspot.gserviceaccount.com via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote: > ...
3 years, 9 months ago (2017-03-15 23:08:04 UTC) #53
chrishtr
Found a fix, it's trivial. Please don't revert.
3 years, 9 months ago (2017-03-15 23:10:57 UTC) #54
chrishtr
https://codereview.chromium.org/2746153007
3 years, 9 months ago (2017-03-15 23:12:13 UTC) #55
chrishtr
3 years, 9 months ago (2017-03-16 00:17:56 UTC) #56
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2751103004/ by chrishtr@chromium.org.

The reason for reverting is: Breaks a chromeos unittest..

Powered by Google App Engine
This is Rietveld 408576698