Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2749533003: [Telemetry] Remove URL from TelemetryInfo. (Closed)

Created:
3 years, 9 months ago by rnephew (Reviews Here)
Modified:
3 years, 9 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Remove URL from TelemetryInfo. It is a hold over from page.Page and is no longer used. Review-Url: https://codereview.chromium.org/2749533003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/22c3fe80d5c522cf5012fd489e5a903216bf5b1a

Patch Set 1 #

Patch Set 2 : [Telemetry] Remove URL from TelemetryInfo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -56 lines) Patch
M docs/histogram-set-json-format.md View 1 2 chunks +0 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/results/page_test_results.py View 4 chunks +0 lines, -7 lines 0 comments Download
M telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tracing/bin/valueset2html View 1 1 chunk +0 lines, -1 line 0 comments Download
M tracing/tracing/metrics/valueset_output_for_compare_samples_test.json View 1 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/value/csv_builder.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M tracing/tracing/value/diagnostics/merged_telemetry_info.html View 1 7 chunks +0 lines, -18 lines 0 comments Download
M tracing/tracing/value/diagnostics/merged_telemetry_info_test.html View 1 3 chunks +0 lines, -3 lines 0 comments Download
M tracing/tracing/value/diagnostics/telemetry_info.html View 1 5 chunks +0 lines, -10 lines 0 comments Download
M tracing/tracing/value/histogram.py View 1 2 chunks +0 lines, -3 lines 0 comments Download
M tracing/tracing/value/histogram_unittest.py View 1 2 chunks +0 lines, -2 lines 0 comments Download
M tracing/tracing/value/ui/merged_telemetry_info_span.html View 1 1 chunk +0 lines, -3 lines 0 comments Download
M tracing/tracing/value/ui/telemetry_info_span.html View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 26 (18 generated)
rnephew (Reviews Here)
3 years, 9 months ago (2017-03-13 18:35:38 UTC) #5
benjhayden
lgtm
3 years, 9 months ago (2017-03-13 19:00:24 UTC) #8
nednguyen
On 2017/03/13 19:00:24, benjhayden wrote: > lgtm I think there are some other references that ...
3 years, 9 months ago (2017-03-13 19:17:52 UTC) #9
rnephew (Reviews Here)
On 2017/03/13 19:17:52, nednguyen wrote: > On 2017/03/13 19:00:24, benjhayden wrote: > > lgtm > ...
3 years, 9 months ago (2017-03-13 20:52:15 UTC) #15
nednguyen
lgtm
3 years, 9 months ago (2017-03-13 20:54:56 UTC) #18
benjhayden
lgtm again
3 years, 9 months ago (2017-03-13 21:59:02 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749533003/60001
3 years, 9 months ago (2017-03-13 22:17:39 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 22:19:58 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698