Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: tracing/tracing/value/diagnostics/telemetry_info.html

Issue 2749533003: [Telemetry] Remove URL from TelemetryInfo. (Closed)
Patch Set: [Telemetry] Remove URL from TelemetryInfo. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/value/diagnostics/telemetry_info.html
diff --git a/tracing/tracing/value/diagnostics/telemetry_info.html b/tracing/tracing/value/diagnostics/telemetry_info.html
index 4bafbbf7f081bfa7926eef5daaea2a3f2487fd04..f8dfb56033b52f1002dab03ec4e4d09f65fe0a45 100644
--- a/tracing/tracing/value/diagnostics/telemetry_info.html
+++ b/tracing/tracing/value/diagnostics/telemetry_info.html
@@ -22,7 +22,6 @@ tr.exportTo('tr.v.d', function() {
this.legacyTIRLabel_ = '';
this.storyDisplayName_ = '';
this.storyGroupingKeys_ = new Map();
- this.storyUrl_ = '';
this.storysetRepeatCounter_ = undefined;
this.canonicalUrl_ = '';
@@ -43,7 +42,6 @@ tr.exportTo('tr.v.d', function() {
* @param {undefined|string} info.label
* @param {undefined|!Object} info.storyGroupingKeys
* @param {undefined|string} info.storyDisplayName
- * @param {undefined|string} info.storyUrl
* @param {number} info.storysetRepeatCounter
* @param {number} info.benchmarkStartMs Milliseconds since Unix epoch.
*/
@@ -63,9 +61,6 @@ tr.exportTo('tr.v.d', function() {
for (let [name, value] of Object.entries(info.storyGroupingKeys || {})) {
this.storyGroupingKeys_.set(name, value);
}
- if (info.storyUrl) {
- this.storyUrl_ = info.storyUrl;
- }
if (info.storysetRepeatCounter !== undefined) {
this.storysetRepeatCounter_ = info.storysetRepeatCounter;
}
@@ -103,7 +98,6 @@ tr.exportTo('tr.v.d', function() {
d.storyGroupingKeys[name] = value;
}
}
- d.storyUrl = this.storyUrl;
d.storysetRepeatCounter = this.storysetRepeatCounter;
d.legacyTIRLabel = this.legacyTIRLabel;
d.canonicalUrl = this.canonicalUrl;
@@ -144,10 +138,6 @@ tr.exportTo('tr.v.d', function() {
return this.storyDisplayName_;
}
- get storyUrl() {
- return this.storyUrl_;
- }
-
get storysetRepeatCounter() {
return this.storysetRepeatCounter_;
}
« no previous file with comments | « tracing/tracing/value/diagnostics/merged_telemetry_info_test.html ('k') | tracing/tracing/value/histogram.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698