Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: tracing/tracing/value/diagnostics/merged_telemetry_info.html

Issue 2749533003: [Telemetry] Remove URL from TelemetryInfo. (Closed)
Patch Set: [Telemetry] Remove URL from TelemetryInfo. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/value/diagnostics/merged_telemetry_info.html
diff --git a/tracing/tracing/value/diagnostics/merged_telemetry_info.html b/tracing/tracing/value/diagnostics/merged_telemetry_info.html
index 7e5babc75805f0ca09ce89dbebc053199573c103..9d34510dbbb234e7dae64a49d071a3132e225bca 100644
--- a/tracing/tracing/value/diagnostics/merged_telemetry_info.html
+++ b/tracing/tracing/value/diagnostics/merged_telemetry_info.html
@@ -21,7 +21,6 @@ tr.exportTo('tr.v.d', function() {
this.legacyTIRLabels_ = new Set();
this.storyDisplayNames_ = new Set();
this.storyGroupingKeys_ = new Map();
- this.storyUrls_ = new Set();
this.storysetRepeatCounters_ = new Set();
}
@@ -51,7 +50,6 @@ tr.exportTo('tr.v.d', function() {
other.storysetRepeatCounters)) {
return false;
}
- if (!tr.b.setsEqual(this.storyUrls, other.storyUrls)) return false;
if (!tr.b.setsEqual(this.benchmarkStartsMs, other.benchmarkStartsMs)) {
return false;
}
@@ -91,9 +89,6 @@ tr.exportTo('tr.v.d', function() {
for (let name of otherDiagnostic.storyDisplayNames) {
this.storyDisplayNames.add(name);
}
- for (let name of otherDiagnostic.storyUrls) {
- this.storyUrls.add(name);
- }
for (let name of otherDiagnostic.storysetRepeatCounters) {
this.storysetRepeatCounters.add(name);
}
@@ -137,9 +132,6 @@ tr.exportTo('tr.v.d', function() {
this.storyGroupingKeys.set(name, new Set([value]));
}
}
- if (otherDiagnostic.storyUrl) {
- this.storyUrls.add(otherDiagnostic.storyUrl);
- }
if (otherDiagnostic.storysetRepeatCounter !== undefined) {
this.storysetRepeatCounters.add(otherDiagnostic.storysetRepeatCounter);
}
@@ -167,9 +159,6 @@ tr.exportTo('tr.v.d', function() {
d.storyGroupingKeys[name] = Array.from(values);
}
}
- if (this.storyUrls.size) {
- d.storyUrls = Array.from(this.storyUrls);
- }
if (this.storysetRepeatCounters.size) {
d.storysetRepeatCounters = Array.from(this.storysetRepeatCounters);
}
@@ -195,9 +184,6 @@ tr.exportTo('tr.v.d', function() {
for (let [name, values] of Object.entries(d.storyGroupingKeys || {})) {
info.storyGroupingKeys_.set(name, new Set(values));
}
- for (let n of d.storyUrls || []) {
- info.storyUrls_.add(n);
- }
for (let n of d.storysetRepeatCounters || []) {
info.storysetRepeatCounters_.add(n);
}
@@ -232,10 +218,6 @@ tr.exportTo('tr.v.d', function() {
return this.storyDisplayNames_;
}
- get storyUrls() {
- return this.storyUrls_;
- }
-
get storysetRepeatCounters() {
return this.storysetRepeatCounters_;
}
« no previous file with comments | « tracing/tracing/value/csv_builder.html ('k') | tracing/tracing/value/diagnostics/merged_telemetry_info_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698