Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: telemetry/telemetry/internal/results/page_test_results.py

Issue 2749533003: [Telemetry] Remove URL from TelemetryInfo. (Closed)
Patch Set: [Telemetry] Remove URL from TelemetryInfo. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/results/page_test_results.py
diff --git a/telemetry/telemetry/internal/results/page_test_results.py b/telemetry/telemetry/internal/results/page_test_results.py
index 561699b1997cc3e3c2e56a846c400b699657bf76..05c27e61d2909f7f547f0b38adde649292e05f13 100644
--- a/telemetry/telemetry/internal/results/page_test_results.py
+++ b/telemetry/telemetry/internal/results/page_test_results.py
@@ -33,7 +33,6 @@ class TelemetryInfo(object):
self._label = None
self._story_display_name = ''
self._story_grouping_keys = {}
- self._story_url = ''
self._storyset_repeat_counter = 0
@property
@@ -70,10 +69,6 @@ class TelemetryInfo(object):
return self._story_display_name
@property
- def story_url(self):
- return self._story_url
-
- @property
def story_grouping_keys(self):
return self._story_grouping_keys
@@ -83,7 +78,6 @@ class TelemetryInfo(object):
def WillRunStory(self, story, storyset_repeat_counter):
self._story_display_name = story.display_name
- self._story_url = story.url
if story.grouping_keys:
self._story_grouping_keys = story.grouping_keys
self._storyset_repeat_counter = storyset_repeat_counter
@@ -100,7 +94,6 @@ class TelemetryInfo(object):
d['label'] = self.label
d['storyDisplayName'] = self.story_display_name
d['storyGroupingKeys'] = self.story_grouping_keys
- d['storyUrl'] = self.story_url
d['storysetRepeatCounter'] = self.storyset_repeat_counter
return d
« no previous file with comments | « docs/histogram-set-json-format.md ('k') | telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698