Rename website_settings UI folders to permission_bubble.

Rename website_settings UI folders to permission_bubble.

BUG=700581
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2748443005
Cr-Commit-Position: refs/heads/master@{#457349}
Committed: https://chromium.googlesource.com/chromium/src/+/fab39f321bd58291b749a5654dd00eac809dd77a

[lgarron, 2017-03-11 01:22:46]

lgarron@chromium.org changed reviewers:
+ raymes@chromium.org, rsesek@chromium.org

[lgarron, 2017-03-11 01:22:47]

raymes@, rsesek@, could you review?

Thus is similar to the 3 parent CLs that split page_info into its own folder.
However, this part is a single CL because:
- There is no OWNERS file fork.
- If the other 3 CLs land without problem, I expect this to land without
problem, too. (I'm pretty confident in `./tools/git/mass-rename.py` – building
with both Cocoa and Views has worked just fine across all relevant CLs).


[1] https://codereview.chromium.org/2741933003
[2] https://codereview.chromium.org/2744933002
[3] https://codereview.chromium.org/2744823004

[lgarron, 2017-03-11 02:16:46]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 02:17:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 02:20:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 02:20:35]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[raymes, 2017-03-13 02:48:21]

Thanks for this cleanup!

lg bur one question below about permission_selector_row

https://codereview.chromium.org/2748443005/diff/1/chrome/browser/ui/permissio...
File chrome/browser/ui/permission_bubble/permission_menu_model.h (right):

https://codereview.chromium.org/2748443005/diff/1/chrome/browser/ui/permissio...
chrome/browser/ui/permission_bubble/permission_menu_model.h:18: class
PermissionMenuModel : public ui::SimpleMenuModel,
This one was discussed on the other CL so whatever the outcome is there we
should update this accordingly :)

https://codereview.chromium.org/2748443005/diff/1/chrome/browser/ui/views/per...
File chrome/browser/ui/views/permission_bubble/permission_selector_row.h
(right):

https://codereview.chromium.org/2748443005/diff/1/chrome/browser/ui/views/per...
chrome/browser/ui/views/permission_bubble/permission_selector_row.h:38: class
PermissionSelectorRow : public views::View {
Should this one be moved here? I think this is for PageInfo?

[Robert Sesek, 2017-03-13 16:35:54]

cocoa/ LGTM

[lgarron, 2017-03-15 17:26:47]

raymes@, I need to rebase before landing (have already move the file as you
asked + merge conflicts), but could you review when you get a chance?

[raymes, 2017-03-16 00:24:27]

lgtm

[lgarron, 2017-03-16 00:56:51]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2017-03-16 00:56:52]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2748443005/#ps20001
(title: "Rebasin'.")

[commit-bot: I haz the power, 2017-03-16 00:57:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 01:07:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 01:07:03]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lgarron, 2017-03-16 01:22:15]

Description was changed from

==========
Rename website_settings UI folders to permission_bubble.

BUG=700581
==========

to

==========
Rename website_settings UI folders to permission_bubble.

BUG=700581
TBR=jochen@chromium.org
==========

[lgarron, 2017-03-16 01:22:19]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2017-03-16 01:22:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 01:34:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 01:34:05]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lgarron, 2017-03-16 01:38:25]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2017-03-16 01:38:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 01:45:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 01:45:59]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lgarron, 2017-03-16 02:07:49]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2017-03-16 02:07:50]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2748443005/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-03-16 02:08:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 04:11:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489630069747130,
"parent_rev": "4562d4a8a6cc89ff20222ca0fe082e42a4625c86", "commit_rev":
"fab39f321bd58291b749a5654dd00eac809dd77a"}

[commit-bot: I haz the power, 2017-03-16 04:11:52]

Description was changed from

==========
Rename website_settings UI folders to permission_bubble.

BUG=700581
TBR=jochen@chromium.org
==========

to

==========
Rename website_settings UI folders to permission_bubble.

BUG=700581
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2748443005
Cr-Commit-Position: refs/heads/master@{#457349}
Committed:
https://chromium.googlesource.com/chromium/src/+/fab39f321bd58291b749a5654dd0...
==========

[commit-bot: I haz the power, 2017-03-16 04:11:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fab39f321bd58291b749a5654dd0...

[tapted, 2017-03-16 08:20:40]

tapted@chromium.org changed reviewers:
+ tapted@chromium.org

[tapted, 2017-03-16 08:20:41]

https://codereview.chromium.org/2748443005/diff/40001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2748443005/diff/40001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:1784: "../browser/ui/passwords/manage_passwords_test.cc",
This sorting isn't right. Everyone will get a presubmit error if they change
this file, so I'm TBRing a formatted CL -
https://codereview.chromium.org/2745253009

(also it looks like jochen was added TBR but not added to the reviewer list -
TBR skips OWNERS checks completely - I don't _think_ it skips other kinds of
presubmit but maybe that's related?)