Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2741933003: Move Cocoa Page Info UI code to its own folder. (Closed)

Created:
3 years, 9 months ago by lgarron
Modified:
3 years, 9 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, felt, mac-reviews_chromium.org, palmer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Cocoa Page Info UI code to its own folder. Includes the following changes: - Forks OWNERS file. - Updates the COMPONENT in both OWNERS files: - website_settings: UI>Browser>Permissions>Prompts - page_info: UI>Browser>Bubbles>PageInfo - Automatically updates filenames across the project using `tools/git/mass-rename.py` Followup work that is NOT part of this change: - Add lgarron@ as an owner (crbug.com/661797) - Move permission prompt UI code into a permission_bubble folder (crbug.com/700581) - Rename classes and corresponding leaf file names (crbug.com/571506) - Functional cleanup changes (crbug.com/571533) BUG=661796 Review-Url: https://codereview.chromium.org/2741933003 Cr-Commit-Position: refs/heads/master@{#456877} Committed: https://chromium.googlesource.com/chromium/src/+/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf

Patch Set 1 #

Patch Set 2 : Move Cocoa Page Info UI code to its own folder. #

Patch Set 3 : Rebase. #

Patch Set 4 : Fixin' more unit tests BUILD paths (does mass_rename.py just not pick those up? => crbug.com/701529) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2322 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/page_info/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/page_info/permission_selector_button.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/page_info/permission_selector_button.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/page_info/permission_selector_button_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/page_info/split_block_button.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/page_info/split_block_button.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/page_info/website_settings_bubble_controller.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/cocoa/page_info/website_settings_bubble_controller.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/page_info/website_settings_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/page_info/website_settings_utils_cocoa.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/page_info/website_settings_utils_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/website_settings/permission_selector_button.h View 1 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/ui/cocoa/website_settings/permission_selector_button.mm View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/ui/cocoa/website_settings/permission_selector_button_unittest.mm View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/ui/cocoa/website_settings/split_block_button.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/ui/cocoa/website_settings/split_block_button.mm View 1 chunk +0 lines, -341 lines 0 comments Download
D chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h View 1 1 chunk +0 lines, -158 lines 0 comments Download
D chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 1 1 chunk +0 lines, -1221 lines 0 comments Download
D chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm View 1 chunk +0 lines, -324 lines 0 comments Download
D chrome/browser/ui/cocoa/website_settings/website_settings_utils_cocoa.h View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/ui/cocoa/website_settings/website_settings_utils_cocoa.mm View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (19 generated)
lgarron
rsesek@, could you review?
3 years, 9 months ago (2017-03-11 00:36:17 UTC) #2
Robert Sesek
Bunch of red trybots, but lgtm
3 years, 9 months ago (2017-03-13 16:30:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741933003/40001
3 years, 9 months ago (2017-03-14 09:16:19 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/373343)
3 years, 9 months ago (2017-03-14 09:30:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741933003/60001
3 years, 9 months ago (2017-03-14 20:36:40 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/340053)
3 years, 9 months ago (2017-03-14 21:53:31 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741933003/60001
3 years, 9 months ago (2017-03-14 21:55:58 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741933003/60001
3 years, 9 months ago (2017-03-14 22:04:11 UTC) #25
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 22:58:22 UTC) #28
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/50ba5edf101710e6ad6f2b03d5f7...

Powered by Google App Engine
This is Rietveld 408576698