Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2744933002: Move Views Page Info UI code to its own folder. (Closed)

Created:
3 years, 9 months ago by lgarron
Modified:
3 years, 9 months ago
Reviewers:
raymes
CC:
benwells, chromium-reviews, felt, mac-reviews_chromium.org, markusheintz_, msramek+watch_chromium.org, palmer, raymes+watch_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Views Page Info UI code to its own folder. Includes the following changes: - Forks OWNERS file. - Updates the COMPONENT in both OWNERS files: - website_settings: UI>Browser>Permissions>Prompts - page_info: UI>Browser>Bubbles>PageInfo - Automatically updates filenames across the project using `tools/git/mass-rename.py` Followup work that is NOT part of this change: - Add lgarron@ as an owner (crbug.com/661797) - Move permission prompt UI code into a permission_bubble folder (crbug.com/700581) - Rename classes and corresponding leaf file names (crbug.com/571506) - Functional cleanup changes (crbug.com/571533) BUG=661796 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2744933002 Cr-Commit-Position: refs/heads/master@{#456974} Committed: https://chromium.googlesource.com/chromium/src/+/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe

Patch Set 1 #

Patch Set 2 : *shakes fist at mass-rename.py* #

Patch Set 3 : Remove CL dependency on the Cocoa changes, for better CQ throughput. #

Patch Set 4 : *shakes other fist at mass-rename.py* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1994 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 2 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/browser_dialogs_views_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_icon_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/page_info/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/page_info/chosen_object_row.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/page_info/chosen_object_row.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/page_info/chosen_object_row_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/page_info/non_accessible_image_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/page_info/non_accessible_image_view.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/page_info/permission_selector_row.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/views/page_info/permission_selector_row.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/page_info/permission_selector_row_observer.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/page_info/website_settings_popup_view.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/ui/views/page_info/website_settings_popup_view.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/views/page_info/website_settings_popup_view_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/page_info/website_settings_popup_view_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/website_settings/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/views/website_settings/chosen_object_row.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/ui/views/website_settings/chosen_object_row.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/ui/views/website_settings/chosen_object_row_observer.h View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/ui/views/website_settings/non_accessible_image_view.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/ui/views/website_settings/non_accessible_image_view.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permission_prompt_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/views/website_settings/permission_selector_row.h View 1 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/browser/ui/views/website_settings/permission_selector_row.cc View 1 1 chunk +0 lines, -351 lines 0 comments Download
D chrome/browser/ui/views/website_settings/permission_selector_row_observer.h View 1 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/ui/views/website_settings/website_settings_popup_view.h View 1 1 chunk +0 lines, -186 lines 0 comments Download
D chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 1 1 chunk +0 lines, -769 lines 0 comments Download
D chrome/browser/ui/views/website_settings/website_settings_popup_view_interactive_uitest.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/ui/views/website_settings/website_settings_popup_view_unittest.cc View 1 1 chunk +0 lines, -268 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 35 (26 generated)
lgarron
raymes@, could you review?
3 years, 9 months ago (2017-03-11 00:19:55 UTC) #2
raymes
lgtm
3 years, 9 months ago (2017-03-13 02:31:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744933002/60001
3 years, 9 months ago (2017-03-14 22:30:44 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/340145) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 9 months ago (2017-03-14 22:40:38 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744933002/80001
3 years, 9 months ago (2017-03-14 23:28:01 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744933002/80001
3 years, 9 months ago (2017-03-14 23:36:38 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/383584)
3 years, 9 months ago (2017-03-15 00:57:26 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744933002/80001
3 years, 9 months ago (2017-03-15 01:37:11 UTC) #32
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 03:08:52 UTC) #35
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/040aad2ebc166c48c8c5bee6582d...

Powered by Google App Engine
This is Rietveld 408576698