Move cross-platform Page Info UI code to its own folder.

Move cross-platform Page Info UI code to its own folder.

Includes the following changes:
- Forks OWNERS file.
- Updates the COMPONENT in both OWNERS files:
  - website_settings: UI>Browser>Permissions>Prompts
  - page_info: UI>Browser>Bubbles>PageInfo
- Automatically updates filenames across the project using
  `tools/git/mass-rename.py`

Followup work that is NOT part of this change:
- Add lgarron@ as an owner (crbug.com/661797)
- Move permission prompt UI code into a permission_bubble folder
  (crbug.com/700581)
- Rename classes and corresponding leaf file names (crbug.com/571506)
- Functional cleanup changes (crbug.com/571533)

BUG=661796
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2744823004
Cr-Commit-Position: refs/heads/master@{#456647}
Committed: https://chromium.googlesource.com/chromium/src/+/58888263da6438b3aa9a68fdec7144c37ca8e73b

[lgarron, 2017-03-11 00:02:02]

lgarron@chromium.org changed reviewers:
+ estark@chromium.org

[lgarron, 2017-03-11 00:02:03]

estark@, could you review?

[lgarron, 2017-03-11 00:02:24]

Description was changed from

==========
Move cross-platform Page Info UI code to its own folder.

Includes the following changes:
- Forks OWNERS file.
- Updates the COMPONENT in both OWNERS files:
  - website_settings: UI>Browser>Permissions>Prompts
  - page_info: UI>Browser>Bubbles>PageInfo
- Automatically updates filenames across the project using `tools/git/mass-
  rename.py`

Followup work that is NOT part of this change:
- Add lgarron@ as an owner (crbug.com/661797)
- Rename classes (crbug.com/571506)
- Move permission prompt UI code into a permission_prompts folder
  (crbug.com/700581)

BUG=661796
==========

to

==========
Move cross-platform Page Info UI code to its own folder.

Includes the following changes:
- Forks OWNERS file.
- Updates the COMPONENT in both OWNERS files:
  - website_settings: UI>Browser>Permissions>Prompts
  - page_info: UI>Browser>Bubbles>PageInfo
- Automatically updates filenames across the project using
  `tools/git/mass-rename.py`

Followup work that is NOT part of this change:
- Add lgarron@ as an owner (crbug.com/661797)
- Rename classes (crbug.com/571506)
- Move permission prompt UI code into a permission_prompts folder
  (crbug.com/700581)

BUG=661796
==========

[lgarron, 2017-03-11 00:03:18]

Description was changed from

==========
Move cross-platform Page Info UI code to its own folder.

Includes the following changes:
- Forks OWNERS file.
- Updates the COMPONENT in both OWNERS files:
  - website_settings: UI>Browser>Permissions>Prompts
  - page_info: UI>Browser>Bubbles>PageInfo
- Automatically updates filenames across the project using
  `tools/git/mass-rename.py`

Followup work that is NOT part of this change:
- Add lgarron@ as an owner (crbug.com/661797)
- Rename classes (crbug.com/571506)
- Move permission prompt UI code into a permission_prompts folder
  (crbug.com/700581)

BUG=661796
==========

to

==========
Move cross-platform Page Info UI code to its own folder.

Includes the following changes:
- Forks OWNERS file.
- Updates the COMPONENT in both OWNERS files:
  - website_settings: UI>Browser>Permissions>Prompts
  - page_info: UI>Browser>Bubbles>PageInfo
- Automatically updates filenames across the project using
  `tools/git/mass-rename.py`

Followup work that is NOT part of this change:
- Add lgarron@ as an owner (crbug.com/661797)
- Rename classes or corresponding leaf file names (crbug.com/571506)
- Move permission prompt UI code into a permission_prompts folder
  (crbug.com/700581)

BUG=661796
==========

[lgarron, 2017-03-11 00:06:16]

Description was changed from

==========
Move cross-platform Page Info UI code to its own folder.

Includes the following changes:
- Forks OWNERS file.
- Updates the COMPONENT in both OWNERS files:
  - website_settings: UI>Browser>Permissions>Prompts
  - page_info: UI>Browser>Bubbles>PageInfo
- Automatically updates filenames across the project using
  `tools/git/mass-rename.py`

Followup work that is NOT part of this change:
- Add lgarron@ as an owner (crbug.com/661797)
- Rename classes or corresponding leaf file names (crbug.com/571506)
- Move permission prompt UI code into a permission_prompts folder
  (crbug.com/700581)

BUG=661796
==========

to

==========
Move cross-platform Page Info UI code to its own folder.

Includes the following changes:
- Forks OWNERS file.
- Updates the COMPONENT in both OWNERS files:
  - website_settings: UI>Browser>Permissions>Prompts
  - page_info: UI>Browser>Bubbles>PageInfo
- Automatically updates filenames across the project using
  `tools/git/mass-rename.py`

Followup work that is NOT part of this change:
- Add lgarron@ as an owner (crbug.com/661797)
- Move permission prompt UI code into a permission_prompts folder
  (crbug.com/700581)
- Rename classes or corresponding leaf file names (crbug.com/571506)
- Functional cleanup changes (crbug.com/571533)

BUG=661796
==========

[lgarron, 2017-03-11 00:36:46]

Description was changed from

==========
Move cross-platform Page Info UI code to its own folder.

Includes the following changes:
- Forks OWNERS file.
- Updates the COMPONENT in both OWNERS files:
  - website_settings: UI>Browser>Permissions>Prompts
  - page_info: UI>Browser>Bubbles>PageInfo
- Automatically updates filenames across the project using
  `tools/git/mass-rename.py`

Followup work that is NOT part of this change:
- Add lgarron@ as an owner (crbug.com/661797)
- Move permission prompt UI code into a permission_prompts folder
  (crbug.com/700581)
- Rename classes or corresponding leaf file names (crbug.com/571506)
- Functional cleanup changes (crbug.com/571533)

BUG=661796
==========

to

==========
Move cross-platform Page Info UI code to its own folder.

Includes the following changes:
- Forks OWNERS file.
- Updates the COMPONENT in both OWNERS files:
  - website_settings: UI>Browser>Permissions>Prompts
  - page_info: UI>Browser>Bubbles>PageInfo
- Automatically updates filenames across the project using
  `tools/git/mass-rename.py`

Followup work that is NOT part of this change:
- Add lgarron@ as an owner (crbug.com/661797)
- Move permission prompt UI code into a permission_prompts folder
  (crbug.com/700581)
- Rename classes and corresponding leaf file names (crbug.com/571506)
- Functional cleanup changes (crbug.com/571533)

BUG=661796
==========

[lgarron, 2017-03-11 01:04:34]

Description was changed from

==========
Move cross-platform Page Info UI code to its own folder.

Includes the following changes:
- Forks OWNERS file.
- Updates the COMPONENT in both OWNERS files:
  - website_settings: UI>Browser>Permissions>Prompts
  - page_info: UI>Browser>Bubbles>PageInfo
- Automatically updates filenames across the project using
  `tools/git/mass-rename.py`

Followup work that is NOT part of this change:
- Add lgarron@ as an owner (crbug.com/661797)
- Move permission prompt UI code into a permission_prompts folder
  (crbug.com/700581)
- Rename classes and corresponding leaf file names (crbug.com/571506)
- Functional cleanup changes (crbug.com/571533)

BUG=661796
==========

to

==========
Move cross-platform Page Info UI code to its own folder.

Includes the following changes:
- Forks OWNERS file.
- Updates the COMPONENT in both OWNERS files:
  - website_settings: UI>Browser>Permissions>Prompts
  - page_info: UI>Browser>Bubbles>PageInfo
- Automatically updates filenames across the project using
  `tools/git/mass-rename.py`

Followup work that is NOT part of this change:
- Add lgarron@ as an owner (crbug.com/661797)
- Move permission prompt UI code into a permission_bubble folder
  (crbug.com/700581)
- Rename classes and corresponding leaf file names (crbug.com/571506)
- Functional cleanup changes (crbug.com/571533)

BUG=661796
==========

[estark, 2017-03-11 01:10:50]

Does mass-rename.py search and replace in comments? If not, and if you haven't
already, might be worth a quick 'git grep' to check for any comments that refer
to these files.

Otherwise, my only question (inline) is about where PermissionMenuModel should
live.

https://codereview.chromium.org/2744823004/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/permission_menu_model.h (right):

https://codereview.chromium.org/2744823004/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/permission_menu_model.h:18: class
PermissionMenuModel : public ui::SimpleMenuModel,
This class is used by both Page Info and permission prompts. Should it live
somewhere where both can depend on it?

[lgarron, 2017-03-11 01:35:40]

I can't find any comments to update.
(That will be relevant once I update class names and leaf file names, though.)

https://codereview.chromium.org/2744823004/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/permission_menu_model.h (right):

https://codereview.chromium.org/2744823004/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/permission_menu_model.h:18: class
PermissionMenuModel : public ui::SimpleMenuModel,
On 2017/03/11 at 01:10:50, estark wrote:
> This class is used by both Page Info and permission prompts. Should it live
somewhere where both can depend on it?

Ooh, good catch. (I thought I had verified that the code for both was exclusive,
but that was a long time back.)

The obvious choices (to me) are to move it up to `chrome/browser/ui` or to push
it down to `chrome/browser/content_settings`. raymes@, any opinions?

[lgarron, 2017-03-11 02:16:47]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 02:17:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 02:20:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 02:20:31]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[raymes, 2017-03-13 02:42:04]

It's kinda confusing that it's used by the PermissionPrompt (looks a bit
hacky) and I think we should probably decouple those things, so I'm ok if
it's moved to page_info for now if it sounds ok to you both?

On Sat, 11 Mar 2017 at 12:35 <lgarron@chromium.org> wrote:

> I can't find any comments to update.
> (That will be relevant once I update class names and leaf file names,
> though.)
>
>
>
>
>
https://codereview.chromium.org/2744823004/diff/1/chrome/browser/ui/website_s...
> File chrome/browser/ui/website_settings/permission_menu_model.h (right):
>
>
>
https://codereview.chromium.org/2744823004/diff/1/chrome/browser/ui/website_s...
> chrome/browser/ui/website_settings/permission_menu_model.h:18: class
> PermissionMenuModel : public ui::SimpleMenuModel,
> On 2017/03/11 at 01:10:50, estark wrote:
> > This class is used by both Page Info and permission prompts. Should it
> live somewhere where both can depend on it?
>
> Ooh, good catch. (I thought I had verified that the code for both was
> exclusive, but that was a long time back.)
>
> The obvious choices (to me) are to move it up to `chrome/browser/ui` or
> to push it down to `chrome/browser/content_settings`. raymes@, any
> opinions?
>
> https://codereview.chromium.org/2744823004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[lgarron, 2017-03-13 22:17:11]

estark@, could you review?

Per Raymes's comment, I've moved permission_menu_model.h to page_info and filed
crbug.com/701001 to remove the dependency from permission prompt code.

I've also rebased to avoid the (1-line include) conflict with
https://codereview.chromium.org/2725783004 that was causing red-trybot-mania.

[lgarron, 2017-03-13 22:17:22]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 22:18:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2017-03-13 22:25:42]

lgtm % moving permission_menu_model_unittest.cc and when the bots are happy

https://codereview.chromium.org/2744823004/diff/40001/chrome/browser/ui/websi...
File chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
(right):

https://codereview.chromium.org/2744823004/diff/40001/chrome/browser/ui/websi...
chrome/browser/ui/website_settings/permission_menu_model_unittest.cc:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
This file should move too, no?

[commit-bot: I haz the power, 2017-03-13 22:28:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 22:28:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[lgarron, 2017-03-14 00:28:01]

https://codereview.chromium.org/2744823004/diff/40001/chrome/browser/ui/websi...
File chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
(right):

https://codereview.chromium.org/2744823004/diff/40001/chrome/browser/ui/websi...
chrome/browser/ui/website_settings/permission_menu_model_unittest.cc:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
On 2017/03/13 at 22:25:42, estark wrote:
> This file should move too, no?

Yep.

[lgarron, 2017-03-14 00:28:05]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 00:28:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 00:36:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 00:36:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lgarron, 2017-03-14 02:49:37]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2017-03-14 02:49:38]

The patchset sent to the CQ was uploaded after l-g-t-m from estark@chromium.org
Link to the patchset: https://codereview.chromium.org/2744823004/#ps80001
(title: "Update test build file with changes not caught by mass-rename.py")

[commit-bot: I haz the power, 2017-03-14 02:50:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 02:58:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 02:58:05]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lgarron, 2017-03-14 07:07:31]

Description was changed from

==========
Move cross-platform Page Info UI code to its own folder.

Includes the following changes:
- Forks OWNERS file.
- Updates the COMPONENT in both OWNERS files:
  - website_settings: UI>Browser>Permissions>Prompts
  - page_info: UI>Browser>Bubbles>PageInfo
- Automatically updates filenames across the project using
  `tools/git/mass-rename.py`

Followup work that is NOT part of this change:
- Add lgarron@ as an owner (crbug.com/661797)
- Move permission prompt UI code into a permission_bubble folder
  (crbug.com/700581)
- Rename classes and corresponding leaf file names (crbug.com/571506)
- Functional cleanup changes (crbug.com/571533)

BUG=661796
==========

to

==========
Move cross-platform Page Info UI code to its own folder.

Includes the following changes:
- Forks OWNERS file.
- Updates the COMPONENT in both OWNERS files:
  - website_settings: UI>Browser>Permissions>Prompts
  - page_info: UI>Browser>Bubbles>PageInfo
- Automatically updates filenames across the project using
  `tools/git/mass-rename.py`

Followup work that is NOT part of this change:
- Add lgarron@ as an owner (crbug.com/661797)
- Move permission prompt UI code into a permission_bubble folder
  (crbug.com/700581)
- Rename classes and corresponding leaf file names (crbug.com/571506)
- Functional cleanup changes (crbug.com/571533)

BUG=661796
TBR=jochen@chromium.org
==========

[lgarron, 2017-03-14 07:07:37]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2017-03-14 07:07:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 07:46:00]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489475257927820,
"parent_rev": "04263813eccfbf85dc2143e4154b3c65b0f036fb", "commit_rev":
"58888263da6438b3aa9a68fdec7144c37ca8e73b"}

[commit-bot: I haz the power, 2017-03-14 07:46:41]

Description was changed from

==========
Move cross-platform Page Info UI code to its own folder.

Includes the following changes:
- Forks OWNERS file.
- Updates the COMPONENT in both OWNERS files:
  - website_settings: UI>Browser>Permissions>Prompts
  - page_info: UI>Browser>Bubbles>PageInfo
- Automatically updates filenames across the project using
  `tools/git/mass-rename.py`

Followup work that is NOT part of this change:
- Add lgarron@ as an owner (crbug.com/661797)
- Move permission prompt UI code into a permission_bubble folder
  (crbug.com/700581)
- Rename classes and corresponding leaf file names (crbug.com/571506)
- Functional cleanup changes (crbug.com/571533)

BUG=661796
TBR=jochen@chromium.org
==========

to

==========
Move cross-platform Page Info UI code to its own folder.

Includes the following changes:
- Forks OWNERS file.
- Updates the COMPONENT in both OWNERS files:
  - website_settings: UI>Browser>Permissions>Prompts
  - page_info: UI>Browser>Bubbles>PageInfo
- Automatically updates filenames across the project using
  `tools/git/mass-rename.py`

Followup work that is NOT part of this change:
- Add lgarron@ as an owner (crbug.com/661797)
- Move permission prompt UI code into a permission_bubble folder
  (crbug.com/700581)
- Rename classes and corresponding leaf file names (crbug.com/571506)
- Functional cleanup changes (crbug.com/571533)

BUG=661796
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2744823004
Cr-Commit-Position: refs/heads/master@{#456647}
Committed:
https://chromium.googlesource.com/chromium/src/+/58888263da6438b3aa9a68fdec71...
==========

[commit-bot: I haz the power, 2017-03-14 07:46:42]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/58888263da6438b3aa9a68fdec71...