[Bindings] Remove redundant ToObject invocation in dictionary toImpl.

[Bindings] Remove redundant ToObject invocation in dictionary toImpl.

Code earlier in the method already checks IsObject, and in that case ToObject
never throws an exception but simply casts the handle type.

Review-Url: https://codereview.chromium.org/2748353003
Cr-Commit-Position: refs/heads/master@{#457539}
Committed: https://chromium.googlesource.com/chromium/src/+/1b1306a03f9c9650c23d2b0d3f48ce1a3282da0d

[jbroman, 2017-03-15 22:11:45]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 22:12:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-03-15 22:19:50]

jbroman@chromium.org changed reviewers:
+ yukishiino@chromium.org

[jbroman, 2017-03-15 22:19:51]

Noticed this while working on dictionary stuff.

[bashi, 2017-03-15 23:49:37]

bashi@chromium.org changed reviewers:
+ bashi@chromium.org

[bashi, 2017-03-15 23:49:37]

lgtm

[commit-bot: I haz the power, 2017-03-16 00:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 00:46:22]

Dry run: This issue passed the CQ dry run.

[Yuki, 2017-03-16 07:10:43]

LGTM.

https://codereview.chromium.org/2748353003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl
(right):

https://codereview.chromium.org/2748353003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl:40:
v8::Local<v8::Object> v8Object = v8Value.As<v8::Object>();
nit: Could you move this cast up to just after line 29 (just after we checked
v8Value->IsObject())?

[haraken, 2017-03-16 08:34:56]

LGTM

[jbroman, 2017-03-16 19:07:10]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2017-03-16 19:07:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yukishiino@chromium.org, bashi@chromium.org
Link to the patchset: https://codereview.chromium.org/2748353003/#ps20001
(title: "cast directly after check")

[commit-bot: I haz the power, 2017-03-16 19:07:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-03-16 19:07:56]

jbroman@chromium.org changed reviewers:
+ haraken@chromium.org

[jbroman, 2017-03-16 19:07:57]

Done. Because of unused variable warnings, I have to either suppress or guard
with {% if members %}. I did the former, because it's shorter.

[commit-bot: I haz the power, 2017-03-16 20:42:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489691230679620,
"parent_rev": "32bbac8bf90b64d438bcfebc417a183f53ddae34", "commit_rev":
"1b1306a03f9c9650c23d2b0d3f48ce1a3282da0d"}

[commit-bot: I haz the power, 2017-03-16 20:43:24]

Description was changed from

==========
[Bindings] Remove redundant ToObject invocation in dictionary toImpl.

Code earlier in the method already checks IsObject, and in that case ToObject
never throws an exception but simply casts the handle type.
==========

to

==========
[Bindings] Remove redundant ToObject invocation in dictionary toImpl.

Code earlier in the method already checks IsObject, and in that case ToObject
never throws an exception but simply casts the handle type.

Review-Url: https://codereview.chromium.org/2748353003
Cr-Commit-Position: refs/heads/master@{#457539}
Committed:
https://chromium.googlesource.com/chromium/src/+/1b1306a03f9c9650c23d2b0d3f48...
==========

[commit-bot: I haz the power, 2017-03-16 20:43:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1b1306a03f9c9650c23d2b0d3f48...

[Yuki, 2017-03-17 06:07:33]

https://codereview.chromium.org/2748353003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl
(right):

https://codereview.chromium.org/2748353003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl:31:
(void)v8Object;
nit: You can use ALLOW_UNUSED_LOCAL, just FYI.

[jbroman, 2017-03-17 14:50:26]

https://codereview.chromium.org/2748353003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl
(right):

https://codereview.chromium.org/2748353003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl:31:
(void)v8Object;
On 2017/03/17 at 06:07:33, Yuki wrote:
> nit: You can use ALLOW_UNUSED_LOCAL, just FYI.

I'd thought that wtf had something and couldn't find it. Hadn't realized that
base's ALLOW_UNUSED_LOCAL was okay now.
https://codereview.chromium.org/2761493002