Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2761493002: [Bindings] Replace void cast with ALLOW_UNUSED_LOCAL in dictionary_v8.cpp.tmpl. (Closed)

Created:
3 years, 9 months ago by jbroman
Modified:
3 years, 9 months ago
Reviewers:
haraken, Yuki
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Bindings] Replace void cast with ALLOW_UNUSED_LOCAL in dictionary_v8.cpp.tmpl. Review-Url: https://codereview.chromium.org/2761493002 Cr-Commit-Position: refs/heads/master@{#457795} Committed: https://chromium.googlesource.com/chromium/src/+/7ad66d248909da6cfdf6d24147e8d097b1bb6202

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
jbroman
3 years, 9 months ago (2017-03-17 14:50:36 UTC) #4
Yuki
LGTM. Thanks for addressing this.
3 years, 9 months ago (2017-03-17 14:52:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761493002/1
3 years, 9 months ago (2017-03-17 14:53:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7ad66d248909da6cfdf6d24147e8d097b1bb6202
3 years, 9 months ago (2017-03-17 16:48:24 UTC) #11
haraken
3 years, 9 months ago (2017-03-17 17:47:57 UTC) #12
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698