[Bindings] Remove redundant ToObject invocation in dictionary toImpl.

third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl

 {% filter format_blink_cpp_source_code %}
 
 {% from 'utilities.cpp.tmpl' import declare_enum_validation_variable %}
 {% include 'copyright_block.txt' %}
 #include "{{v8_original_class}}.h"
 
 {% for filename in cpp_includes if filename != '%s.h' % v8_class %}
 #include "{{filename}}"
 {% endfor %}
 
 namespace blink {
 
 {% from 'utilities.cpp.tmpl' import v8_value_to_local_cpp_value %}
 void {{v8_class}}::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, {{cpp_class}}& impl, ExceptionState& exceptionState) {
   if (isUndefinedOrNull(v8Value)) {
     {% if required_member_names %}
     exceptionState.throwTypeError("Missing required member(s): {{required_member_names|join(', ')}}.");
     {% endif %}
     return;
   }
   if (!v8Value->IsObject()) {
     {% if use_permissive_dictionary_conversion %}
     // Do nothing.
     return;
     {% else %}
     exceptionState.throwTypeError("cannot convert to dictionary.");
     return;
     {% endif %}
   }
+  v8::Local<v8::Object> v8Object = v8Value.As<v8::Object>();
+  (void)v8Object;

[Yuki, 2017/03/17 06:07:33]

nit: You can use ALLOW_UNUSED_LOCAL, just FYI.

[jbroman, 2017/03/17 14:50:26]

I'd thought that wtf had something and couldn't find it. Hadn't realized that
base's ALLOW_UNUSED_LOCAL was okay now.
https://codereview.chromium.org/2761493002

 
   {% if parent_v8_class %}
   {{parent_v8_class}}::toImpl(isolate, v8Value, impl, exceptionState);
   if (exceptionState.hadException())
     return;
 
   {% endif %}
   {# Declare local variables only when the dictionary has members to avoid unused variable warnings. #}
   {% if members %}
   v8::TryCatch block(isolate);
-  v8::Local<v8::Object> v8Object;
-  if (!v8Call(v8Value->ToObject(isolate->GetCurrentContext()), v8Object, block)) {
-    exceptionState.rethrowV8Exception(block.Exception());
-    return;
-  }
   {% endif %}
   {% for member in members %}
   {% filter runtime_enabled(member.runtime_enabled_feature_name) %}
   v8::Local<v8::Value> {{member.name}}Value;
   if (!v8Object->Get(isolate->GetCurrentContext(), v8AtomicString(isolate, "{{member.name}}")).ToLocal(&{{member.name}}Value)) {
     exceptionState.rethrowV8Exception(block.Exception());
     return;
   }
   if ({{member.name}}Value.IsEmpty() || {{member.name}}Value->IsUndefined()) {
     {% if member.is_required %}
@@ skipping 74 matching lines @@
 
 {{cpp_class}} NativeValueTraits<{{cpp_class}}>::nativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState) {
   {{cpp_class}} impl;
   {{v8_class}}::toImpl(isolate, value, impl, exceptionState);
   return impl;
 }
 
 }  // namespace blink
 
 {% endfilter %}{# format_blink_cpp_source_code #}