third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp - Issue 2748353003: [Bindings] Remove redundant ToObject invocation in dictionary toImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

Issue 2748353003: [Bindings] Remove redundant ToObject invocation in dictionary toImpl. (Closed)

Patch Set: cast directly after check Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

index d0c61ba531b5f789571817ffc072b963948f876f..ec34f5fa0f99184955328e9c6e741108fc8b66db 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

@@ -25,13 +25,10 @@ void V8TestPermissiveDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Valu

// Do nothing.

return;

}

+ v8::Local<v8::Object> v8Object = v8Value.As<v8::Object>();

+ (void)v8Object;

v8::TryCatch block(isolate);

- v8::Local<v8::Object> v8Object;

- if (!v8Call(v8Value->ToObject(isolate->GetCurrentContext()), v8Object, block)) {

- exceptionState.rethrowV8Exception(block.Exception());

- return;

- }

v8::Local<v8::Value> booleanMemberValue;

if (!v8Object->Get(isolate->GetCurrentContext(), v8AtomicString(isolate, "booleanMember")).ToLocal(&booleanMemberValue)) {

exceptionState.rethrowV8Exception(block.Exception());