Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

Issue 2748023006: [DevTools] Make ConsoleModel not inherit from SDKModel (Closed)
Patch Set: stray change Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
index 7fe44929c70d94e4401a8c62f982929a0c26b0f6..4278f1ef34b8ee78e492a83c24d3df015fa30838 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
@@ -971,7 +971,6 @@ SDK.targetManager.observeTargets({
InspectorTest.RuntimeAgent = target.runtimeAgent();
InspectorTest.TargetAgent = target.targetAgent();
- InspectorTest.consoleModel = target.consoleModel;
InspectorTest.networkManager = SDK.NetworkManager.fromTarget(target);
InspectorTest.securityOriginManager = SDK.SecurityOriginManager.fromTarget(target);
InspectorTest.resourceTreeModel = SDK.ResourceTreeModel.fromTarget(target);
@@ -988,6 +987,7 @@ SDK.targetManager.observeTargets({
InspectorTest.serviceWorkerManager = target.model(SDK.ServiceWorkerManager);
InspectorTest.tracingManager = target.model(SDK.TracingManager);
InspectorTest.mainTarget = target;
+ Promise.resolve().then(() => { InspectorTest.consoleModel = SDK.multitargetConsoleModel._consoleModels.get(target); });
},
targetRemoved: function(target) { }

Powered by Google App Engine
This is Rietveld 408576698