third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js - Issue 2748023006: [DevTools] Make ConsoleModel not inherit from SDKModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2748023006: [DevTools] Make ConsoleModel not inherit from SDKModel (Closed)

Patch Set: stray change Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js ('k') | third_party/WebKit/Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

index 3ca49b02a7b8b99e3ae01ce721d822ce4af2416b..0284371beb975c1851a658e665c48526717b47e1 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

@@ -182,8 +182,7 @@ Console.ConsoleView = class extends UI.VBox {

}

static clearConsole() {

- for (var target of SDK.targetManager.targets())

- target.consoleModel.requestClearMessages();

+ SDK.multitargetConsoleModel.requestClearMessages();

}

/**

@@ -806,7 +805,7 @@ Console.ConsoleView = class extends UI.VBox {

result.target(), exceptionDetails, SDK.ConsoleMessage.MessageType.Result, undefined, undefined);

}

message.setOriginatingMessage(originatingConsoleMessage);

- result.target().consoleModel.addMessage(message);

+ SDK.multitargetConsoleModel.addMessage(message);

}

/**