Migrate WTF::Deque::remove() to ::erase()

Migrate WTF::Deque::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
Review-Url: https://codereview.chromium.org/2747373004
Cr-Commit-Position: refs/heads/master@{#457097}
Committed: https://chromium.googlesource.com/chromium/src/+/e1dd04d3aa422d619a76153946c2cf0061ed4e43

[pilgrim_google, 2017-03-15 13:39:38]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[pilgrim_google, 2017-03-15 13:39:50]

pilgrim@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, yutak@chromium.org

[commit-bot: I haz the power, 2017-03-15 13:39:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-03-15 13:40:33]

LGTM

[pilgrim_google, 2017-03-15 15:03:30]

The CQ bit was unchecked by pilgrim@chromium.org

[pilgrim_google, 2017-03-15 15:03:32]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2017-03-15 15:03:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 16:06:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489590212520390, "parent_rev":
"c9af99aa1d6d8caec1992e0f62f37e3cf54296ac", "commit_rev":
"e1dd04d3aa422d619a76153946c2cf0061ed4e43"}

[commit-bot: I haz the power, 2017-03-15 16:06:50]

Description was changed from

==========
Migrate WTF::Deque::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

to

==========
Migrate WTF::Deque::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431

Review-Url: https://codereview.chromium.org/2747373004
Cr-Commit-Position: refs/heads/master@{#457097}
Committed:
https://chromium.googlesource.com/chromium/src/+/e1dd04d3aa422d619a76153946c2...
==========

[commit-bot: I haz the power, 2017-03-15 16:06:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e1dd04d3aa422d619a76153946c2...

[huangs, 2017-03-15 18:13:54]

huangs@chromium.org changed reviewers:
+ huangs@chromium.org

[huangs, 2017-03-15 18:13:55]

I suspect this CL is causing failure in chromium.linux/Linux Tests (dbg)(1), and
crashing test
WebSiteSettingsPopupViewBrowserTest.ChromeURL .

[huangs, 2017-03-15 18:20:56]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2751053003/ by huangs@chromium.org.

The reason for reverting is: This CL is suspected of crashing
  WebSiteSettingsPopupViewBrowserTest.ChromeURL
for chromium.linux/Linux Tests (dbg)(1). Justifications:
- This is the first failure in a long time.
- This CL is the only C++ CL in the batch.
- Crash occurs in a destructor, and this CL deals with deallocation..

[huangs, 2017-03-15 18:39:34]

Revert is scratched for now: It got blocked by another change, but the crash
also disappeared.