Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: third_party/WebKit/Source/wtf/DequeTest.cpp

Issue 2747373004: Migrate WTF::Deque::remove() to ::erase() (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/wtf/Deque.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 572 matching lines...) Expand 10 before | Expand all | Expand 10 after
583 // All numbers present. 583 // All numbers present.
584 { 584 {
585 int i = 0; 585 int i = 0;
586 for (int v : deque) 586 for (int v : deque)
587 EXPECT_EQ(i++, v); 587 EXPECT_EQ(i++, v);
588 } 588 }
589 589
590 // Remove the even numbers while iterating. 590 // Remove the even numbers while iterating.
591 for (auto it = deque.begin(); it != deque.end(); ++it) { 591 for (auto it = deque.begin(); it != deque.end(); ++it) {
592 if (*it % 2 == 0) { 592 if (*it % 2 == 0) {
593 deque.remove(it); 593 deque.erase(it);
594 --it; 594 --it;
595 } 595 }
596 } 596 }
597 597
598 // Only odd numbers left. 598 // Only odd numbers left.
599 { 599 {
600 int i = 1; 600 int i = 1;
601 for (int v : deque) 601 for (int v : deque)
602 EXPECT_EQ(i + 2, v); 602 EXPECT_EQ(i + 2, v);
603 } 603 }
(...skipping 25 matching lines...) Expand all
629 EXPECT_EQ(2u, deque.size()); 629 EXPECT_EQ(2u, deque.size());
630 EXPECT_EQ(3, deque[0].value1); 630 EXPECT_EQ(3, deque[0].value1);
631 EXPECT_EQ(4, deque[0].value2); 631 EXPECT_EQ(4, deque[0].value2);
632 EXPECT_EQ(1, deque[1].value1); 632 EXPECT_EQ(1, deque[1].value1);
633 EXPECT_EQ(2, deque[1].value2); 633 EXPECT_EQ(2, deque[1].value2);
634 } 634 }
635 635
636 } // anonymous namespace 636 } // anonymous namespace
637 637
638 } // namespace WTF 638 } // namespace WTF
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/wtf/Deque.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698