third_party/WebKit/Source/core/dom/ScriptRunner.cpp - Issue 2747373004: Migrate WTF::Deque::remove() to ::erase()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ScriptRunner.cpp

Issue 2747373004: Migrate WTF::Deque::remove() to ::erase() (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ScriptRunner.cpp

diff --git a/third_party/WebKit/Source/core/dom/ScriptRunner.cpp b/third_party/WebKit/Source/core/dom/ScriptRunner.cpp

index 333c2d8e254a4c5f224f5ebbe6c6719594f6d160..69056c01ec07501b8760fcd4327ca7ed492377b8 100644

--- a/third_party/WebKit/Source/core/dom/ScriptRunner.cpp

+++ b/third_party/WebKit/Source/core/dom/ScriptRunner.cpp

@@ -142,7 +142,7 @@ bool ScriptRunner::removePendingInOrderScript(ScriptLoader* scriptLoader) {

m_pendingInOrderScripts.end(), scriptLoader);

if (it == m_pendingInOrderScripts.end())

return false;

- m_pendingInOrderScripts.remove(it);

+ m_pendingInOrderScripts.erase(it);

SECURITY_CHECK(m_numberOfInOrderScriptsWithPendingNotification > 0);

m_numberOfInOrderScriptsWithPendingNotification--;

return true;