third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp - Issue 2747373004: Migrate WTF::Deque::remove() to ::erase()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp

Issue 2747373004: Migrate WTF::Deque::remove() to ::erase() (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp b/third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp

index df7e4ede8dbdfcf8b84a20166e2355829021a385..8ecb8159cfc35e4b9ec4a0b72497426fded8f727 100644

--- a/third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp

@@ -355,7 +355,7 @@ inline Element* SharedStyleFinder::findElementForStyleSharing() const {

continue;

if (it != styleSharingList.begin()) {

// Move the element to the front of the LRU

- styleSharingList.remove(it);

+ styleSharingList.erase(it);

styleSharingList.prepend(&candidate);

}

return &candidate;