Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 27471002: Implement crop rect support for SkMatrixConvolutionImageFilter. (Closed)

Created:
5 years, 10 months ago by Stephen White
Modified:
5 years, 10 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Implement crop rect support for SkMatrixConvolutionImageFilter. R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=11863

Patch Set 1 #

Patch Set 2 : Fix style issues, GM size, add ignored-tests.txt suppression. #

Patch Set 3 : Implement GPU backend support #

Patch Set 4 : Fix comment #

Total comments: 6

Patch Set 5 : Fix style issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -83 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M gm/matrixconvolution.cpp View 1 2 3 4 3 chunks +31 lines, -12 lines 0 comments Download
M include/core/SkImageFilter.h View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M include/effects/SkMagnifierImageFilter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkMatrixConvolutionImageFilter.h View 1 2 3 chunks +30 lines, -6 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 2 25 chunks +117 lines, -54 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Stephen White
Brian: PTAL. Thanks!
5 years, 10 months ago (2013-10-18 18:45:27 UTC) #1
bsalomon
lgtm w/ a couple small inline comments https://codereview.chromium.org/27471002/diff/36001/gm/matrixconvolution.cpp File gm/matrixconvolution.cpp (right): https://codereview.chromium.org/27471002/diff/36001/gm/matrixconvolution.cpp#newcode80 gm/matrixconvolution.cpp:80: typedef SkMatrixConvolutionImageFilter ...
5 years, 10 months ago (2013-10-18 18:56:22 UTC) #2
reed1
https://codereview.chromium.org/27471002/diff/36001/include/core/SkImageFilter.h File include/core/SkImageFilter.h (right): https://codereview.chromium.org/27471002/diff/36001/include/core/SkImageFilter.h#newcode190 include/core/SkImageFilter.h:190: const SkIRect& bounds) const; shot in the dark : ...
5 years, 10 months ago (2013-10-18 18:57:35 UTC) #3
Stephen White
On 2013/10/18 18:57:35, reed1 wrote: > https://codereview.chromium.org/27471002/diff/36001/include/core/SkImageFilter.h > File include/core/SkImageFilter.h (right): > > https://codereview.chromium.org/27471002/diff/36001/include/core/SkImageFilter.h#newcode190 > ...
5 years, 10 months ago (2013-10-18 19:47:16 UTC) #4
Stephen White
Thanks for your review! https://codereview.chromium.org/27471002/diff/36001/gm/matrixconvolution.cpp File gm/matrixconvolution.cpp (right): https://codereview.chromium.org/27471002/diff/36001/gm/matrixconvolution.cpp#newcode97 gm/matrixconvolution.cpp:97: draw(canvas, 310, 10, target, MCIF::kClamp_TileMode, ...
5 years, 10 months ago (2013-10-18 20:05:44 UTC) #5
Stephen White
5 years, 10 months ago (2013-10-18 20:08:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 manually as r11863 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698