[Device Service] Port ScreenOrientationListener into Device Service.

[Device Service] Port ScreenOrientationListener into Device Service.

ScreenOrientationListener interface does not require ordering with
ScreenOrientation, so we can simply decouple it from //content to let it
being hosted in Device Service.

BUG=678545
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2745443002
Cr-Commit-Position: refs/heads/master@{#457021}
Committed: https://chromium.googlesource.com/chromium/src/+/bb3acfe64e6fe8405bda628b059567e0ca3f451e

[leonhsl(Using Gerrit), 2017-03-09 03:00:57]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 03:01:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 04:02:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 04:02:53]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[leonhsl(Using Gerrit), 2017-03-09 05:17:02]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 05:17:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 06:37:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 06:37:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[leonhsl(Using Gerrit), 2017-03-09 06:53:03]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 06:53:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 07:26:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 07:26:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[leonhsl(Using Gerrit), 2017-03-09 07:38:33]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 07:38:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 08:02:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 08:02:34]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2017-03-09 08:22:30]

leon.han@intel.com changed reviewers:
+ blundell@chromium.org, mlamouri@chromium.org

[leonhsl(Using Gerrit), 2017-03-09 08:22:31]

PTAL, thanks! A follow-up CL will remove
//content/renderer/screen_orientation/screen_orientation_observer.* and let
Blink consume ScreenOrientationListener directly.

https://codereview.chromium.org/2745443002/diff/20001/services/device/screen_...
File services/device/screen_orientation/screen_orientation_listener_android.cc
(right):

https://codereview.chromium.org/2745443002/diff/20001/services/device/screen_...
services/device/screen_orientation/screen_orientation_listener_android.cc:17:
mojo::MakeStrongBinding(
ScreenOrientationListenerAndroid lives on IO thread, one instance per Renderer
Process. This is the same behavior with before.

[blundell, 2017-03-09 16:48:20]

nice!

lgtm, thanks

https://codereview.chromium.org/2745443002/diff/20001/content/common/screen_o...
File content/common/screen_orientation_messages.h (left):

https://codereview.chromium.org/2745443002/diff/20001/content/common/screen_o...
content/common/screen_orientation_messages.h:16: #define IPC_MESSAGE_START
ScreenOrientationMsgStart
This bugfix is unrelated to the rest of this CL, correct? If so, I would split
it out into its own little CL.

https://codereview.chromium.org/2745443002/diff/20001/services/device/manifes...
File services/device/manifest.json (right):

https://codereview.chromium.org/2745443002/diff/20001/services/device/manifes...
services/device/manifest.json:8: "device:screen_orientation": [
"device::mojom::ScreenOrientationListener" ],
nit: let's call this screen_orientation_listener

[leonhsl(Using Gerrit), 2017-03-10 02:43:06]

https://codereview.chromium.org/2745443002/diff/20001/content/common/screen_o...
File content/common/screen_orientation_messages.h (left):

https://codereview.chromium.org/2745443002/diff/20001/content/common/screen_o...
content/common/screen_orientation_messages.h:16: #define IPC_MESSAGE_START
ScreenOrientationMsgStart
On 2017/03/09 16:48:20, blundell (OOO until March 13) wrote:
> This bugfix is unrelated to the rest of this CL, correct? If so, I would split
> it out into its own little CL.

Oh, this relates with this CL's work.
ScreenOrientationMsgStart was used to make a BrowserMessageFilter at line14 in
https://codereview.chromium.org/2745443002/diff/20001/content/browser/screen_...,
but now this CL decouples this file into Device Service and do not expect it to
be a BrowserMessageFilter, thus we can delete ScreenOrientationMsgStart here.

https://codereview.chromium.org/2745443002/diff/20001/services/device/manifes...
File services/device/manifest.json (right):

https://codereview.chromium.org/2745443002/diff/20001/services/device/manifes...
services/device/manifest.json:8: "device:screen_orientation": [
"device::mojom::ScreenOrientationListener" ],
On 2017/03/09 16:48:20, blundell (OOO until March 13) wrote:
> nit: let's call this screen_orientation_listener

I was considering to append also device::mojom::ScreenOrientation into this
category in future, so I named it as device:screen_orientation.
At last would be just like:
"device:screen_orientation": [
  "device::mojom::ScreenOrientation",
  "device::mojom::ScreenOrientationListener",
],

WDYT? Thanks~

[leonhsl(Using Gerrit), 2017-03-13 02:53:52]

Ping Mounir, Thanks~

[leonhsl(Using Gerrit), 2017-03-14 03:22:32]

leon.han@intel.com changed reviewers:
+ kinuko@chromium.org, tsepez@chromium.org

[leonhsl(Using Gerrit), 2017-03-14 03:22:33]

+kinuko@ and tsepez@, would you please take an OWNER review for this? Thanks!

As Colin has helped to confirm with Mounir that there has no strict ordering
obligation between ScreenOrientationListener and ScreenOrientation, the
consensus has been made that we can host ScreenOrientationListener under Device
Service right now, so I'm sure Mounir has no objection to what this CL is doing.

kinuko@ : //content/*

tsepez@ : 
content/common/screen_orientation_messages.h
content/public/app/mojo/content_renderer_manifest.json
ipc/ipc_message_start.h
services/device/manifest.json

[kinuko, 2017-03-14 04:22:25]

On 2017/03/14 03:22:33, leonhsl wrote:
> +kinuko@ and tsepez@, would you please take an OWNER review for this? Thanks!
> 
> As Colin has helped to confirm with Mounir that there has no strict ordering
> obligation between ScreenOrientationListener and ScreenOrientation, the
> consensus has been made that we can host ScreenOrientationListener under
Device
> Service right now, so I'm sure Mounir has no objection to what this CL is
doing.
> 
> kinuko@ : //content/*

lgtm

> tsepez@ : 
> content/common/screen_orientation_messages.h
> content/public/app/mojo/content_renderer_manifest.json
> ipc/ipc_message_start.h
> services/device/manifest.json

[Tom Sepez, 2017-03-14 16:20:15]

LGTM otherwise.

https://codereview.chromium.org/2745443002/diff/20001/content/common/screen_o...
File content/common/screen_orientation_messages.h (right):

https://codereview.chromium.org/2745443002/diff/20001/content/common/screen_o...
content/common/screen_orientation_messages.h:16: // Only used by
content/common/manifest_manager_messages.h.
Maybe we can delete this file entirely and move the one remaining trait to the
aforementioned file or content/common/content_param_traits_macros.h ?

[leonhsl(Using Gerrit), 2017-03-15 02:07:34]

Thanks all! Will send to CQ now.

https://codereview.chromium.org/2745443002/diff/20001/content/common/screen_o...
File content/common/screen_orientation_messages.h (right):

https://codereview.chromium.org/2745443002/diff/20001/content/common/screen_o...
content/common/screen_orientation_messages.h:16: // Only used by
content/common/manifest_manager_messages.h.
On 2017/03/14 16:20:15, Tom Sepez wrote:
> Maybe we can delete this file entirely and move the one remaining trait to the
> aforementioned file or content/common/content_param_traits_macros.h 

Yeah I think we should do this. I'd like to prepare a follow-up CL for your
review, because it's somehow another different task with this one :)

[leonhsl(Using Gerrit), 2017-03-15 02:07:43]

The CQ bit was checked by leon.han@intel.com

[commit-bot: I haz the power, 2017-03-15 02:08:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 02:16:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 02:16:39]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[leonhsl(Using Gerrit), 2017-03-15 02:37:45]

Let me TBR sky@ for adding DEPS, Thanks!
  services/device/screen_orientation/DEPS  --> Depends on
mojo/public/cpp/bindings
  services/device/screen_orientation/android/java/DEPS  --> Depends on
ui/android/java

[leonhsl(Using Gerrit), 2017-03-15 02:38:55]

Description was changed from

==========
[Device Service] Port ScreenOrientationListener into Device Service.

ScreenOrientationListener interface does not require ordering with
ScreenOrientation, so we can simply decouple it from //content to let it
being hosted in Device Service.

BUG=678545
==========

to

==========
[Device Service] Port ScreenOrientationListener into Device Service.

ScreenOrientationListener interface does not require ordering with
ScreenOrientation, so we can simply decouple it from //content to let it
being hosted in Device Service.

BUG=678545
TBR=sky@chromium.org
==========

[leonhsl(Using Gerrit), 2017-03-15 02:39:18]

The CQ bit was checked by leon.han@intel.com

[commit-bot: I haz the power, 2017-03-15 02:39:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-03-15 02:41:03]

leon.han@intel.com changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2017-03-15 05:17:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 05:17:25]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[leonhsl(Using Gerrit), 2017-03-15 05:22:46]

The CQ bit was checked by leon.han@intel.com

[commit-bot: I haz the power, 2017-03-15 05:23:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 07:11:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489555366201760,
"parent_rev": "fc599795d2c67209375dddfe4806d9b58a5f1905", "commit_rev":
"bb3acfe64e6fe8405bda628b059567e0ca3f451e"}

[commit-bot: I haz the power, 2017-03-15 07:12:08]

Description was changed from

==========
[Device Service] Port ScreenOrientationListener into Device Service.

ScreenOrientationListener interface does not require ordering with
ScreenOrientation, so we can simply decouple it from //content to let it
being hosted in Device Service.

BUG=678545
TBR=sky@chromium.org
==========

to

==========
[Device Service] Port ScreenOrientationListener into Device Service.

ScreenOrientationListener interface does not require ordering with
ScreenOrientation, so we can simply decouple it from //content to let it
being hosted in Device Service.

BUG=678545
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2745443002
Cr-Commit-Position: refs/heads/master@{#457021}
Committed:
https://chromium.googlesource.com/chromium/src/+/bb3acfe64e6fe8405bda628b0595...
==========

[commit-bot: I haz the power, 2017-03-15 07:12:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bb3acfe64e6fe8405bda628b0595...

[sky, 2017-03-15 15:25:24]

LGTM