services/device/manifest.json - Issue 2745443002: [Device Service] Port ScreenOrientationListener into Device Service.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/device/manifest.json

Issue 2745443002: [Device Service] Port ScreenOrientationListener into Device Service. (Closed)

Patch Set: Add DEPS Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/common/screen_orientation_messages.h ('K') | « services/device/device_service.cc ('k') | services/device/screen_orientation/BUILD.gn » ('j') | services/device/screen_orientation/screen_orientation_listener_android.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "name": "device",	2 "name": "device",

3 "display_name": "Device Service",	3 "display_name": "Device Service",

4 "interface_provider_specs": {	4 "interface_provider_specs": {

5 "service_manager:connector": {	5 "service_manager:connector": {

6 "provides": {	6 "provides": {

7 "device:power_monitor": [ "device::mojom::PowerMonitor" ],	7 "device:power_monitor": [ "device::mojom::PowerMonitor" ],

	8 "device:screen_orientation": [ "device::mojom::ScreenOrientationListener " ],
	blundell 2017/03/09 16:48:20 nit: let's call this screen_orientation_listener nit: let's call this screen_orientation_listener leonhsl(Using Gerrit) 2017/03/10 02:43:06 I was considering to append also device::mojom::Sc Show quoted text On 2017/03/09 16:48:20, blundell (OOO until March 13) wrote: > nit: let's call this screen_orientation_listener I was considering to append also device::mojom::ScreenOrientation into this category in future, so I named it as device:screen_orientation. At last would be just like: "device:screen_orientation": [ "device::mojom::ScreenOrientation", "device::mojom::ScreenOrientationListener", ], WDYT? Thanks~
8 "device:time_zone_monitor": [ "device::mojom::TimeZoneMonitor" ],	9 "device:time_zone_monitor": [ "device::mojom::TimeZoneMonitor" ],

9 "device:fingerprint": [ "device::mojom::Fingerprint" ]	10 "device:fingerprint": [ "device::mojom::Fingerprint" ]

10 },	11 },

11 "requires": {	12 "requires": {

12 "service_manager": [ "service_manager:all_users" ]	13 "service_manager": [ "service_manager:all_users" ]

13 }	14 }

14 }	15 }

15 }	16 }

16 }	17 }

OLD	NEW