Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: services/device/device_service.cc

Issue 2745443002: [Device Service] Port ScreenOrientationListener into Device Service. (Closed)
Patch Set: Add DEPS Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/device/device_service.cc
diff --git a/services/device/device_service.cc b/services/device/device_service.cc
index 0044460a1d9c1dd4bb4d99313ae24f2582b861bb..f9bd085c75ac674dbeb17aecd383a8b1cc2510ea 100644
--- a/services/device/device_service.cc
+++ b/services/device/device_service.cc
@@ -7,6 +7,7 @@
#include "base/bind.h"
#include "base/memory/ptr_util.h"
#include "base/memory/weak_ptr.h"
+#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
#include "services/device/fingerprint/fingerprint.h"
#include "services/device/power_monitor/power_monitor_message_broadcaster.h"
@@ -16,12 +17,14 @@
#if defined(OS_ANDROID)
#include "services/device/android/register_jni.h"
+#include "services/device/screen_orientation/screen_orientation_listener_android.h"
#endif
namespace device {
std::unique_ptr<service_manager::Service> CreateDeviceService(
- scoped_refptr<base::SingleThreadTaskRunner> file_task_runner) {
+ scoped_refptr<base::SingleThreadTaskRunner> file_task_runner,
+ scoped_refptr<base::SingleThreadTaskRunner> io_task_runner) {
#if defined(OS_ANDROID)
if (!EnsureJniRegistered()) {
DLOG(ERROR) << "Failed to register JNI for Device Service";
@@ -29,12 +32,15 @@ std::unique_ptr<service_manager::Service> CreateDeviceService(
}
#endif
- return base::MakeUnique<DeviceService>(std::move(file_task_runner));
+ return base::MakeUnique<DeviceService>(std::move(file_task_runner),
+ std::move(io_task_runner));
}
DeviceService::DeviceService(
- scoped_refptr<base::SingleThreadTaskRunner> file_task_runner)
- : file_task_runner_(std::move(file_task_runner)) {}
+ scoped_refptr<base::SingleThreadTaskRunner> file_task_runner,
+ scoped_refptr<base::SingleThreadTaskRunner> io_task_runner)
+ : file_task_runner_(std::move(file_task_runner)),
+ io_task_runner_(std::move(io_task_runner)) {}
DeviceService::~DeviceService() {}
@@ -44,7 +50,9 @@ bool DeviceService::OnConnect(const service_manager::ServiceInfo& remote_info,
service_manager::InterfaceRegistry* registry) {
registry->AddInterface<mojom::Fingerprint>(this);
registry->AddInterface<mojom::PowerMonitor>(this);
+ registry->AddInterface<mojom::ScreenOrientationListener>(this);
registry->AddInterface<mojom::TimeZoneMonitor>(this);
+
return true;
}
@@ -63,9 +71,20 @@ void DeviceService::Create(const service_manager::Identity& remote_identity,
}
void DeviceService::Create(const service_manager::Identity& remote_identity,
+ mojom::ScreenOrientationListenerRequest request) {
+#if defined(OS_ANDROID)
+ if (io_task_runner_) {
+ io_task_runner_->PostTask(
+ FROM_HERE, base::Bind(&ScreenOrientationListenerAndroid::Create,
+ base::Passed(&request)));
+ }
+#endif
+}
+
+void DeviceService::Create(const service_manager::Identity& remote_identity,
mojom::TimeZoneMonitorRequest request) {
if (!time_zone_monitor_)
- time_zone_monitor_ = device::TimeZoneMonitor::Create(file_task_runner_);
+ time_zone_monitor_ = TimeZoneMonitor::Create(file_task_runner_);
time_zone_monitor_->Bind(std::move(request));
}

Powered by Google App Engine
This is Rietveld 408576698