content/common/screen_orientation_messages.h - Issue 2745443002: [Device Service] Port ScreenOrientationListener into Device Service.

Side by Side Diff: content/common/screen_orientation_messages.h

Issue 2745443002: [Device Service] Port ScreenOrientationListener into Device Service. (Closed)

Patch Set: Add DEPS Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « content/browser/service_manager/service_manager_context.cc ('k') | content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java » ('j') | services/device/manifest.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // IPC messages for screen orientation.	5 // IPC messages for screen orientation.

6 // Multiply-included message file, hence no include guard.	6 // Multiply-included message file, hence no include guard.

7	7

8 #include "content/common/content_export.h"	8 #include "content/common/content_export.h"

9 #include "ipc/ipc_message_macros.h"	9 #include "ipc/ipc_message_macros.h"

10 #include "third_party/WebKit/public/platform/modules/screen_orientation/WebLockO rientationError.h"	10 #include "third_party/WebKit/public/platform/modules/screen_orientation/WebLockO rientationError.h"

11 #include "third_party/WebKit/public/platform/modules/screen_orientation/WebScree nOrientationLockType.h"	11 #include "third_party/WebKit/public/platform/modules/screen_orientation/WebScree nOrientationLockType.h"

12	12

13 #undef IPC_MESSAGE_EXPORT	13 #undef IPC_MESSAGE_EXPORT

14 #define IPC_MESSAGE_EXPORT CONTENT_EXPORT	14 #define IPC_MESSAGE_EXPORT CONTENT_EXPORT

15	15

16 #define IPC_MESSAGE_START ScreenOrientationMsgStart
blundell 2017/03/09 16:48:20 This bugfix is unrelated to the rest of this CL, c This bugfix is unrelated to the rest of this CL, correct? If so, I would split it out into its own little CL. leonhsl(Using Gerrit) 2017/03/10 02:43:06 Oh, this relates with this CL's work. ScreenOrient Show quoted text On 2017/03/09 16:48:20, blundell (OOO until March 13) wrote: > This bugfix is unrelated to the rest of this CL, correct? If so, I would split > it out into its own little CL. Oh, this relates with this CL's work. ScreenOrientationMsgStart was used to make a BrowserMessageFilter at line14 in https://codereview.chromium.org/2745443002/diff/20001/content/browser/screen_..., but now this CL decouples this file into Device Service and do not expect it to be a BrowserMessageFilter, thus we can delete ScreenOrientationMsgStart here.
17

18 // Only used by content/common/manifest_manager_messages.h.	16 // Only used by content/common/manifest_manager_messages.h.
	Tom Sepez 2017/03/14 16:20:15 Maybe we can delete this file entirely and move th Maybe we can delete this file entirely and move the one remaining trait to the aforementioned file or content/common/content_param_traits_macros.h ? leonhsl(Using Gerrit) 2017/03/15 02:07:34 Yeah I think we should do this. I'd like to prepar Show quoted text On 2017/03/14 16:20:15, Tom Sepez wrote: > Maybe we can delete this file entirely and move the one remaining trait to the > aforementioned file or content/common/content_param_traits_macros.h Yeah I think we should do this. I'd like to prepare a follow-up CL for your review, because it's somehow another different task with this one :)
19 IPC_ENUM_TRAITS_MIN_MAX_VALUE(blink::WebScreenOrientationLockType,	17 IPC_ENUM_TRAITS_MIN_MAX_VALUE(blink::WebScreenOrientationLockType,

20 blink::WebScreenOrientationLockDefault,	18 blink::WebScreenOrientationLockDefault,

21 blink::WebScreenOrientationLockNatural)	19 blink::WebScreenOrientationLockNatural)

OLD	NEW