Improve doc of ViewObserver and clarify arguments

Improve doc of ViewObserver and clarify arguments

This is motivated by making it possible to share use the same
ViewObserver with many views.

BUG=none
TEST=none
R=bsep@chromium.org

Review-Url: https://codereview.chromium.org/2745163003
Cr-Commit-Position: refs/heads/master@{#456932}
Committed: https://chromium.googlesource.com/chromium/src/+/a9fac83ffe6ac844faaed0f5b6f59edbac461ec0

[sky, 2017-03-13 16:15:46]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 16:16:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 17:33:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 17:33:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bret, 2017-03-14 18:58:36]

lgtm, makes ViewObserver much less confusing, thanks!

https://codereview.chromium.org/2745163003/diff/20001/ui/views/view_unittest.cc
File ui/views/view_unittest.cc (right):

https://codereview.chromium.org/2745163003/diff/20001/ui/views/view_unittest....
ui/views/view_unittest.cc:4881: void OnChildViewAdded(View* parent, View* child)
override {
add a couple lines to the existing unit tests that verify the parent argument is
actually the parent, for this and OnChildViewReordered below

[sky, 2017-03-14 20:19:29]

https://codereview.chromium.org/2745163003/diff/20001/ui/views/view_unittest.cc
File ui/views/view_unittest.cc (right):

https://codereview.chromium.org/2745163003/diff/20001/ui/views/view_unittest....
ui/views/view_unittest.cc:4881: void OnChildViewAdded(View* parent, View* child)
override {
On 2017/03/14 18:58:36, Bret Sepulveda wrote:
> add a couple lines to the existing unit tests that verify the parent argument
is
> actually the parent, for this and OnChildViewReordered below

Done.

[sky, 2017-03-14 20:19:40]

The CQ bit was checked by sky@chromium.org

[sky, 2017-03-14 20:19:40]

The patchset sent to the CQ was uploaded after l-g-t-m from bsep@chromium.org
Link to the patchset: https://codereview.chromium.org/2745163003/#ps40001
(title: "test coverage")

[commit-bot: I haz the power, 2017-03-14 20:20:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-03-14 20:35:33]

The CQ bit was unchecked by sky@chromium.org

[sky, 2017-03-14 23:46:22]

The CQ bit was checked by sky@chromium.org

[sky, 2017-03-14 23:46:22]

The patchset sent to the CQ was uploaded after l-g-t-m from bsep@chromium.org
Link to the patchset: https://codereview.chromium.org/2745163003/#ps60001
(title: "merge")

[commit-bot: I haz the power, 2017-03-14 23:47:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 01:06:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489535182457080,
"parent_rev": "cf7da999a0c77771e582ed3e29e56c79027655a7", "commit_rev":
"a9fac83ffe6ac844faaed0f5b6f59edbac461ec0"}

[commit-bot: I haz the power, 2017-03-15 01:07:36]

Description was changed from

==========
Improve doc of ViewObserver and clarify arguments

This is motivated by making it possible to share use the same
ViewObserver with many views.

BUG=none
TEST=none
R=bsep@chromium.org
==========

to

==========
Improve doc of ViewObserver and clarify arguments

This is motivated by making it possible to share use the same
ViewObserver with many views.

BUG=none
TEST=none
R=bsep@chromium.org

Review-Url: https://codereview.chromium.org/2745163003
Cr-Commit-Position: refs/heads/master@{#456932}
Committed:
https://chromium.googlesource.com/chromium/src/+/a9fac83ffe6ac844faaed0f5b6f5...
==========

[commit-bot: I haz the power, 2017-03-15 01:07:38]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a9fac83ffe6ac844faaed0f5b6f5...