Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2247)

Unified Diff: ash/common/devtools/ash_devtools_dom_agent.cc

Issue 2745163003: Improve doc of ViewObserver and clarify arguments (Closed)
Patch Set: merge Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/devtools/ash_devtools_dom_agent.h ('k') | ui/views/view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/devtools/ash_devtools_dom_agent.cc
diff --git a/ash/common/devtools/ash_devtools_dom_agent.cc b/ash/common/devtools/ash_devtools_dom_agent.cc
index f72c249729ee601f47d6d0e626e8cdfaa268531c..058f10ea29e0c20c2669b6060f0f9ba3f3a0bd42 100644
--- a/ash/common/devtools/ash_devtools_dom_agent.cc
+++ b/ash/common/devtools/ash_devtools_dom_agent.cc
@@ -185,17 +185,19 @@ void AshDevToolsDOMAgent::OnWidgetBoundsChanged(views::Widget* widget,
observer.OnWidgetBoundsChanged(widget);
}
-void AshDevToolsDOMAgent::OnChildViewRemoved(views::View* view,
- views::View* parent) {
+void AshDevToolsDOMAgent::OnChildViewRemoved(views::View* parent,
+ views::View* view) {
RemoveViewTree(view, parent, true);
}
-void AshDevToolsDOMAgent::OnChildViewAdded(views::View* view) {
+void AshDevToolsDOMAgent::OnChildViewAdded(views::View* parent,
+ views::View* view) {
AddViewTree(view);
}
-void AshDevToolsDOMAgent::OnChildViewReordered(views::View* view) {
- RemoveViewTree(view, view->parent(), false);
+void AshDevToolsDOMAgent::OnChildViewReordered(views::View* parent,
+ views::View* view) {
+ RemoveViewTree(view, parent, false);
AddViewTree(view);
}
« no previous file with comments | « ash/common/devtools/ash_devtools_dom_agent.h ('k') | ui/views/view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698