Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1433)

Unified Diff: ui/views/view.cc

Issue 2745163003: Improve doc of ViewObserver and clarify arguments (Closed)
Patch Set: merge Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/devtools/ash_devtools_dom_agent.cc ('k') | ui/views/view_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/view.cc
diff --git a/ui/views/view.cc b/ui/views/view.cc
index 86624f8a2f6c59939bfa1d3a1ecbd335aec8fecb..a67ae7f942901f34ae79b0ddc871ab9d6b9b460e 100644
--- a/ui/views/view.cc
+++ b/ui/views/view.cc
@@ -255,7 +255,7 @@ void View::AddChildViewAt(View* view, int index) {
layout_manager_->ViewAdded(this, view);
for (ViewObserver& observer : observers_)
- observer.OnChildViewAdded(view);
+ observer.OnChildViewAdded(this, view);
}
void View::ReorderChildView(View* view, int index) {
@@ -287,7 +287,7 @@ void View::ReorderChildView(View* view, int index) {
children_.insert(children_.begin() + index, view);
for (ViewObserver& observer : observers_)
- observer.OnChildViewReordered(view);
+ observer.OnChildViewReordered(this, view);
ReorderLayers();
}
@@ -1967,7 +1967,7 @@ void View::DoRemoveChildView(View* view,
layout_manager_->ViewRemoved(this, view);
for (ViewObserver& observer : observers_)
- observer.OnChildViewRemoved(view, this);
+ observer.OnChildViewRemoved(this, view);
}
void View::PropagateRemoveNotifications(View* old_parent,
« no previous file with comments | « ash/common/devtools/ash_devtools_dom_agent.cc ('k') | ui/views/view_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698