Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Side by Side Diff: ash/common/devtools/ash_devtools_dom_agent.h

Issue 2745163003: Improve doc of ViewObserver and clarify arguments (Closed)
Patch Set: merge Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ash/common/devtools/ash_devtools_dom_agent.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_DOM_AGENT_H_ 5 #ifndef ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_DOM_AGENT_H_
6 #define ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_DOM_AGENT_H_ 6 #define ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_DOM_AGENT_H_
7 7
8 #include "ash/ash_export.h" 8 #include "ash/ash_export.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/observer_list.h" 10 #include "base/observer_list.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 const gfx::Rect& new_bounds) override; 60 const gfx::Rect& new_bounds) override;
61 61
62 // views::WidgetRemovalsObserver 62 // views::WidgetRemovalsObserver
63 void OnWillRemoveView(views::Widget* widget, views::View* view) override; 63 void OnWillRemoveView(views::Widget* widget, views::View* view) override;
64 64
65 // views::WidgetObserver 65 // views::WidgetObserver
66 void OnWidgetBoundsChanged(views::Widget* widget, 66 void OnWidgetBoundsChanged(views::Widget* widget,
67 const gfx::Rect& new_bounds) override; 67 const gfx::Rect& new_bounds) override;
68 68
69 // views::ViewObserver 69 // views::ViewObserver
70 void OnChildViewRemoved(views::View* view, views::View* parent) override; 70 void OnChildViewRemoved(views::View* parent, views::View* view) override;
71 void OnChildViewAdded(views::View* view) override; 71 void OnChildViewAdded(views::View* parent, views::View* view) override;
72 void OnChildViewReordered(views::View*) override; 72 void OnChildViewReordered(views::View* parent, views::View*) override;
73 void OnViewBoundsChanged(views::View* view) override; 73 void OnViewBoundsChanged(views::View* view) override;
74 74
75 WmWindow* GetWindowFromNodeId(int nodeId); 75 WmWindow* GetWindowFromNodeId(int nodeId);
76 views::Widget* GetWidgetFromNodeId(int nodeId); 76 views::Widget* GetWidgetFromNodeId(int nodeId);
77 views::View* GetViewFromNodeId(int nodeId); 77 views::View* GetViewFromNodeId(int nodeId);
78 78
79 int GetNodeIdFromWindow(WmWindow* window); 79 int GetNodeIdFromWindow(WmWindow* window);
80 int GetNodeIdFromWidget(views::Widget* widget); 80 int GetNodeIdFromWidget(views::Widget* widget);
81 int GetNodeIdFromView(views::View* view); 81 int GetNodeIdFromView(views::View* view);
82 82
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 148
149 base::ObserverList<AshDevToolsDOMAgentObserver> observers_; 149 base::ObserverList<AshDevToolsDOMAgentObserver> observers_;
150 150
151 DISALLOW_COPY_AND_ASSIGN(AshDevToolsDOMAgent); 151 DISALLOW_COPY_AND_ASSIGN(AshDevToolsDOMAgent);
152 }; 152 };
153 153
154 } // namespace devtools 154 } // namespace devtools
155 } // namespace ash 155 } // namespace ash
156 156
157 #endif // ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_DOM_AGENT_H_ 157 #endif // ASH_COMMON_DEVTOOLS_ASH_DEVTOOLS_DOM_AGENT_H_
OLDNEW
« no previous file with comments | « no previous file | ash/common/devtools/ash_devtools_dom_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698