Fix LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted with PlzNavigate.

Fix LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted with PlzNavigate.

Ensure that when loadDataWithBaseUrl is called, onPageStarted uses the base url for the data url.

BUG=645983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2745033002
Cr-Commit-Position: refs/heads/master@{#456814}
Committed: https://chromium.googlesource.com/chromium/src/+/75284b4387797789ea4d56447e1ab3d6f8091199

[jam, 2017-03-13 06:57:11]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2017-03-13 06:57:23]

The CQ bit was unchecked by jam@chromium.org

[commit-bot: I haz the power, 2017-03-13 06:57:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-03-13 06:58:27]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 06:58:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 07:43:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 07:43:05]

Dry run: This issue passed the CQ dry run.

[jam, 2017-03-13 14:31:15]

jam@chromium.org changed reviewers:
+ sgurun@chromium.org

[sgurun-gerrit only, 2017-03-14 00:23:02]

On 2017/03/13 14:31:16, jam wrote:

that does not look like the right fix. Loaddatawithbaseurl behavior is
definitely poorly documented, but it is possible that applications calling
loaddatawithbaseurl are waiting for that url.

Further, with plznagivation, it seems like onpagestarted is called twice, one
for the base url and one for the data one.

[jam, 2017-03-14 05:39:35]

Description was changed from

==========
Fix LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted with
PlzNavigate.

The test was created for bug 327391 to ensure that when loadDataWithBaseUrl is
used, onPageStarted was being called. That's happening with PlzNavigate.

However it also asserted that the URL was the base url. Without PlzNavigate,
onPageStarted used that URL since that's what
WebContentsObserver::DidStartNavigation used. Note that even without
PlzNavigate, when the navigation committed the data URL instead of the base url.
With PlzNavigate, the data URL is always used (in onPageStarted,
WebContentsObserver::DidStartNavigation and
WebContentsObserver::DidFinishNavigation).

BUG=645983
==========

to

==========
Fix LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted with
PlzNavigate.

The test was created for bug 327391 to ensure that when loadDataWithBaseUrl is
used, onPageStarted was being called. That's happening with PlzNavigate.

However it also asserted that the URL was the base url. Without PlzNavigate,
onPageStarted used that URL since that's what
WebContentsObserver::DidStartNavigation used. Note that even without
PlzNavigate, when the navigation committed the data URL instead of the base url.
With PlzNavigate, the data URL is always used (in onPageStarted,
WebContentsObserver::DidStartNavigation and
WebContentsObserver::DidFinishNavigation).

BUG=645983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2017-03-14 05:42:51]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 05:43:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-03-14 05:56:07]

Patchset #4 (id:60001) has been deleted

[jam, 2017-03-14 05:56:16]

Patchset #3 (id:40001) has been deleted

[jam, 2017-03-14 05:57:20]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 05:57:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-03-14 06:21:44]

Description was changed from

==========
Fix LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted with
PlzNavigate.

The test was created for bug 327391 to ensure that when loadDataWithBaseUrl is
used, onPageStarted was being called. That's happening with PlzNavigate.

However it also asserted that the URL was the base url. Without PlzNavigate,
onPageStarted used that URL since that's what
WebContentsObserver::DidStartNavigation used. Note that even without
PlzNavigate, when the navigation committed the data URL instead of the base url.
With PlzNavigate, the data URL is always used (in onPageStarted,
WebContentsObserver::DidStartNavigation and
WebContentsObserver::DidFinishNavigation).

BUG=645983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted with
PlzNavigate.

Ensure that when loadDataWithBaseUrl is caooed, onPageStarted uses the base url
for the data url.

BUG=645983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2017-03-14 06:22:59]

On 2017/03/14 00:23:02, sgurun wrote:
> On 2017/03/13 14:31:16, jam wrote:
> 
> that does not look like the right fix. Loaddatawithbaseurl behavior is
> definitely poorly documented, but it is possible that applications calling
> loaddatawithbaseurl are waiting for that url.

Good point, ok I've plumbed the base url for data url value through so that the
behavior doesn't change.

> 
> Further, with plznagivation, it seems like onpagestarted is called twice, one
> for the base url and one for the data one.

How did you see this btw? I only see one call.

[commit-bot: I haz the power, 2017-03-14 06:59:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 06:59:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-03-14 07:12:58]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 07:13:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 07:58:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 07:58:47]

Dry run: This issue passed the CQ dry run.

[jam, 2017-03-14 19:56:07]

Description was changed from

==========
Fix LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted with
PlzNavigate.

Ensure that when loadDataWithBaseUrl is caooed, onPageStarted uses the base url
for the data url.

BUG=645983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted with
PlzNavigate.

Ensure that when loadDataWithBaseUrl is called, onPageStarted uses the base url
for the data url.

BUG=645983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[sgurun-gerrit only, 2017-03-14 20:20:16]

lgtm

[jam, 2017-03-14 20:21:51]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-03-14 20:22:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 20:29:19]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1489522911819380,
"parent_rev": "a6f2c9d9dd10c89bbad1b7cca078ab8da7eeb59e", "commit_rev":
"75284b4387797789ea4d56447e1ab3d6f8091199"}

[commit-bot: I haz the power, 2017-03-14 20:29:59]

Description was changed from

==========
Fix LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted with
PlzNavigate.

Ensure that when loadDataWithBaseUrl is called, onPageStarted uses the base url
for the data url.

BUG=645983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted with
PlzNavigate.

Ensure that when loadDataWithBaseUrl is called, onPageStarted uses the base url
for the data url.

BUG=645983
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2745033002
Cr-Commit-Position: refs/heads/master@{#456814}
Committed:
https://chromium.googlesource.com/chromium/src/+/75284b4387797789ea4d56447e1a...
==========

[commit-bot: I haz the power, 2017-03-14 20:30:00]

Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/75284b4387797789ea4d56447e1a...