chrome/browser/ui/android/external_protocol_dialog_android.cc - Issue 2745033002: Fix LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted with PlzNavigate.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/android/external_protocol_dialog_android.cc

Issue 2745033002: Fix LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted with PlzNavigate. (Closed)

Patch Set: fix unittest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | components/navigation_interception/intercept_navigation_throttle.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/external_protocol/external_protocol_handler.h"	5 #include "chrome/browser/external_protocol/external_protocol_handler.h"

6	6

7 #include "base/logging.h"	7 #include "base/logging.h"

8 #include "chrome/browser/external_protocol/external_protocol_handler.h"	8 #include "chrome/browser/external_protocol/external_protocol_handler.h"

9 #include "chrome/browser/tab_contents/tab_util.h"	9 #include "chrome/browser/tab_contents/tab_util.h"

10 #include "components/navigation_interception/intercept_navigation_delegate.h"	10 #include "components/navigation_interception/intercept_navigation_delegate.h"

(...skipping 21 matching lines...) Expand all Loading...
32 return;	32 return;

33	33

34 navigation_interception::NavigationParams navigation_params(	34 navigation_interception::NavigationParams navigation_params(

35 url,	35 url,

36 content::Referrer(),	36 content::Referrer(),

37 has_user_gesture, // has_user_gesture	37 has_user_gesture, // has_user_gesture

38 false, // is_post, doesn't matter here.	38 false, // is_post, doesn't matter here.

39 page_transition,	39 page_transition,

40 false, // is_redirect, doesn't matter here.	40 false, // is_redirect, doesn't matter here.

41 true, // is_external_protocol	41 true, // is_external_protocol

42 false); // is_main_frame	42 false, // is_main_frame

	43 GURL()); // base_url_for_data_url, not applicable.

43 delegate->ShouldIgnoreNavigation(navigation_params);	44 delegate->ShouldIgnoreNavigation(navigation_params);

44 }	45 }

OLD	NEW