Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: chrome/browser/ui/android/external_protocol_dialog_android.cc

Issue 2745033002: Fix LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted with PlzNavigate. (Closed)
Patch Set: fix unittest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/navigation_interception/intercept_navigation_throttle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/android/external_protocol_dialog_android.cc
diff --git a/chrome/browser/ui/android/external_protocol_dialog_android.cc b/chrome/browser/ui/android/external_protocol_dialog_android.cc
index 5ce3e65148e9c93016d3763de9d389ab41606aaa..56851e1d277c4b3e857558b164f99bab30e11f0e 100644
--- a/chrome/browser/ui/android/external_protocol_dialog_android.cc
+++ b/chrome/browser/ui/android/external_protocol_dialog_android.cc
@@ -39,6 +39,7 @@ void ExternalProtocolHandler::RunExternalProtocolDialog(
page_transition,
false, // is_redirect, doesn't matter here.
true, // is_external_protocol
- false); // is_main_frame
+ false, // is_main_frame
+ GURL()); // base_url_for_data_url, not applicable.
delegate->ShouldIgnoreNavigation(navigation_params);
}
« no previous file with comments | « no previous file | components/navigation_interception/intercept_navigation_throttle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698