components/navigation_interception/intercept_navigation_throttle.cc - Issue 2745033002: Fix LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted with PlzNavigate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/navigation_interception/intercept_navigation_throttle.cc

Issue 2745033002: Fix LoadDataWithBaseUrlTest#testloadDataWithBaseUrlCallsOnPageStarted with PlzNavigate. (Closed)

Patch Set: fix unittest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/external_protocol_dialog_android.cc ('k') | components/navigation_interception/navigation_params.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/navigation_interception/intercept_navigation_throttle.cc

diff --git a/components/navigation_interception/intercept_navigation_throttle.cc b/components/navigation_interception/intercept_navigation_throttle.cc

index 84292c9f8bb201cb2eb98f1eeb99e05dbe5be8cb..c66a302286ec08a919b8f3e931b0c5cdce8f4a99 100644

--- a/components/navigation_interception/intercept_navigation_throttle.cc

+++ b/components/navigation_interception/intercept_navigation_throttle.cc

@@ -69,7 +69,8 @@ InterceptNavigationThrottle::CheckIfShouldIgnoreNavigation(bool is_redirect) {

navigation_handle()->GetURL(), navigation_handle()->GetReferrer(),

navigation_handle()->HasUserGesture(), navigation_handle()->IsPost(),

navigation_handle()->GetPageTransition(), is_redirect,

- navigation_handle()->IsExternalProtocol(), true);

+ navigation_handle()->IsExternalProtocol(), true,

+ navigation_handle()->GetBaseURLForDataURL());

if (run_callback_synchronously_) {

bool should_ignore_navigation = should_ignore_callback_.Run(