[simulator] remove unused argument field for stop/breaks.

[simulator] remove unused argument field for stop/breaks.

We used to embed a string address as description right after
a stop instruction, which the simulator would read and print.
We removed that a while ago to make the snapshot predictable.

R=petermarshall@chromium.org
BUG=v8:6071
Review-Url: https://codereview.chromium.org/2744503003
Cr-Commit-Position: refs/heads/master@{#43698}
Committed: https://chromium.googlesource.com/v8/v8/+/0ca72de24cc2b697bf8af91d5c3901495bf962d8

[petermarshall, 2017-03-09 11:37:36]

https://codereview.chromium.org/2744503003/diff/1/src/mips64/assembler-mips64.cc
File src/mips64/assembler-mips64.cc (right):

https://codereview.chromium.org/2744503003/diff/1/src/mips64/assembler-mips64...
src/mips64/assembler-mips64.cc:2268: void Assembler::stop(const char* msg,
uint32_t code) {
msg is no longer used at all - could it be removed too? There seem to be a lot
of callers that still provide a msg, but it is totally ignored. It could be
confusing to someone running/debugging the code who expects to see the msg
output somewhere.

[Yang, 2017-03-09 12:27:18]

On 2017/03/09 11:37:36, petermarshall wrote:
>
https://codereview.chromium.org/2744503003/diff/1/src/mips64/assembler-mips64.cc
> File src/mips64/assembler-mips64.cc (right):
> 
>
https://codereview.chromium.org/2744503003/diff/1/src/mips64/assembler-mips64...
> src/mips64/assembler-mips64.cc:2268: void Assembler::stop(const char* msg,
> uint32_t code) {
> msg is no longer used at all - could it be removed too? There seem to be a lot
> of callers that still provide a msg, but it is totally ignored. It could be
> confusing to someone running/debugging the code who expects to see the msg
> output somewhere.

Actually, let's keep them as sort of comment. We do this elsewhere too, for
example SnapshotByteSink::Put.

[petermarshall, 2017-03-09 12:39:19]

lgtm

OK sounds good

[Yang, 2017-03-09 12:39:36]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2017-03-09 12:39:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 13:40:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489063176199590, "parent_rev":
"21880a5357a13843489d3407b1afcde28ca9c191", "commit_rev":
"0ca72de24cc2b697bf8af91d5c3901495bf962d8"}

[commit-bot: I haz the power, 2017-03-09 13:40:35]

Description was changed from

==========
[simulator] remove unused argument field for stop/breaks.

We used to embed a string address as description right after
a stop instruction, which the simulator would read and print.
We removed that a while ago to make the snapshot predictable.

R=petermarshall@chromium.org
BUG=v8:6071
==========

to

==========
[simulator] remove unused argument field for stop/breaks.

We used to embed a string address as description right after
a stop instruction, which the simulator would read and print.
We removed that a while ago to make the snapshot predictable.

R=petermarshall@chromium.org
BUG=v8:6071

Review-Url: https://codereview.chromium.org/2744503003
Cr-Commit-Position: refs/heads/master@{#43698}
Committed:
https://chromium.googlesource.com/v8/v8/+/0ca72de24cc2b697bf8af91d5c3901495bf...
==========

[commit-bot: I haz the power, 2017-03-09 13:40:35]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0ca72de24cc2b697bf8af91d5c3901495bf...