Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: src/mips/assembler-mips.cc

Issue 2744503003: [simulator] remove unused argument field for stop/breaks. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/mips/assembler-mips.cc
diff --git a/src/mips/assembler-mips.cc b/src/mips/assembler-mips.cc
index 784185ac0d2c3a190c8613e2d35929469f706d3b..444d90f678095adff7898a6c48108fbc41d40409 100644
--- a/src/mips/assembler-mips.cc
+++ b/src/mips/assembler-mips.cc
@@ -2020,14 +2020,7 @@ void Assembler::stop(const char* msg, uint32_t code) {
break_(0x54321);
#else // V8_HOST_ARCH_MIPS
BlockTrampolinePoolFor(2);
- // The Simulator will handle the stop instruction and get the message address.
- // On MIPS stop() is just a special kind of break_().
break_(code, true);
- // Do not embed the message string address! We used to do this, but that
- // made snapshots created from position-independent executable builds
- // non-deterministic.
- // TODO(yangguo): remove this field entirely.
- nop();
#endif
}

Powered by Google App Engine
This is Rietveld 408576698