Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: src/arm/assembler-arm.cc

Issue 2744503003: [simulator] remove unused argument field for stop/breaks. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm/disasm-arm.cc » ('j') | src/mips64/assembler-mips64.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 2264 matching lines...) Expand 10 before | Expand all | Expand 10 after
2275 } 2275 }
2276 2276
2277 2277
2278 // Exception-generating instructions and debugging support. 2278 // Exception-generating instructions and debugging support.
2279 // Stops with a non-negative code less than kNumOfWatchedStops support 2279 // Stops with a non-negative code less than kNumOfWatchedStops support
2280 // enabling/disabling and a counter feature. See simulator-arm.h . 2280 // enabling/disabling and a counter feature. See simulator-arm.h .
2281 void Assembler::stop(const char* msg, Condition cond, int32_t code) { 2281 void Assembler::stop(const char* msg, Condition cond, int32_t code) {
2282 #ifndef __arm__ 2282 #ifndef __arm__
2283 DCHECK(code >= kDefaultStopCode); 2283 DCHECK(code >= kDefaultStopCode);
2284 { 2284 {
2285 // The Simulator will handle the stop instruction and get the message
2286 // address. It expects to find the address just after the svc instruction.
2287 BlockConstPoolScope block_const_pool(this); 2285 BlockConstPoolScope block_const_pool(this);
2288 if (code >= 0) { 2286 if (code >= 0) {
2289 svc(kStopCode + code, cond); 2287 svc(kStopCode + code, cond);
2290 } else { 2288 } else {
2291 svc(kStopCode + kMaxStopCode, cond); 2289 svc(kStopCode + kMaxStopCode, cond);
2292 } 2290 }
2293 // Do not embed the message string address! We used to do this, but that
2294 // made snapshots created from position-independent executable builds
2295 // non-deterministic.
2296 // TODO(yangguo): remove this field entirely.
2297 nop();
2298 } 2291 }
2299 #else // def __arm__ 2292 #else // def __arm__
2300 if (cond != al) { 2293 if (cond != al) {
2301 Label skip; 2294 Label skip;
2302 b(&skip, NegateCondition(cond)); 2295 b(&skip, NegateCondition(cond));
2303 bkpt(0); 2296 bkpt(0);
2304 bind(&skip); 2297 bind(&skip);
2305 } else { 2298 } else {
2306 bkpt(0); 2299 bkpt(0);
2307 } 2300 }
(...skipping 3026 matching lines...) Expand 10 before | Expand all | Expand 10 after
5334 DCHECK(is_uint12(offset)); 5327 DCHECK(is_uint12(offset));
5335 instr_at_put(pc, SetLdrRegisterImmediateOffset(instr, offset)); 5328 instr_at_put(pc, SetLdrRegisterImmediateOffset(instr, offset));
5336 } 5329 }
5337 } 5330 }
5338 5331
5339 5332
5340 } // namespace internal 5333 } // namespace internal
5341 } // namespace v8 5334 } // namespace v8
5342 5335
5343 #endif // V8_TARGET_ARCH_ARM 5336 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/disasm-arm.cc » ('j') | src/mips64/assembler-mips64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698