Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2742213002: bindings: Make v8_union iterate through its members by type name (Closed)

Created:
3 years, 9 months ago by Raphael Kubo da Costa (rakuco)
Modified:
3 years, 9 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Make v8_union iterate through its members by type name This is being done in preparation for supporting flattening union member types and deal with nested union types. A union's flattened member types are represented as a set, so once we start using it to generate the union V8->C++ conversion code we will need to do so in a deterministic way. This specific change just makes the current code iterate through its member types sorted by name to update existing test expectations and reduce the size of the upcoming nested union support patch. BUG=700225 R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org Review-Url: https://codereview.chromium.org/2742213002 Cr-Commit-Position: refs/heads/master@{#456338} Committed: https://chromium.googlesource.com/chromium/src/+/a328b46a04ef32a9afdbed84930042c6d5b0d87f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -178 lines) Patch
M third_party/WebKit/Source/bindings/scripts/v8_union.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/ByteStringSequenceSequenceOrByteStringByteStringRecord.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/ByteStringSequenceSequenceOrByteStringByteStringRecord.cpp View 2 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringOrArrayBufferOrArrayBufferView.h View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringOrArrayBufferOrArrayBufferView.cpp View 3 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.cpp View 2 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp View 3 chunks +19 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.cpp View 2 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.cpp View 2 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/UnrestrictedDoubleOrString.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/UnrestrictedDoubleOrString.cpp View 2 chunks +18 lines, -18 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
Raphael Kubo da Costa (rakuco)
PTAL. This is groundwork for https://codereview.chromium.org/2746713003
3 years, 9 months ago (2017-03-12 14:56:05 UTC) #1
haraken
LGTM
3 years, 9 months ago (2017-03-12 15:15:59 UTC) #4
bashi
lgtm
3 years, 9 months ago (2017-03-12 23:41:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742213002/1
3 years, 9 months ago (2017-03-13 08:38:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a328b46a04ef32a9afdbed84930042c6d5b0d87f
3 years, 9 months ago (2017-03-13 08:42:16 UTC) #12
Yuki
3 years, 9 months ago (2017-03-13 08:43:27 UTC) #13
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698