Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.h

Issue 2742213002: bindings: Make v8_union iterate through its members by type name (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.h
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.h b/third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.h
index 570ebe3277d8a597ba38f2dd2a2138aa788dd682..0d2d147f29d15a5b3e0c6e83aed067690efd8f23 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.h
+++ b/third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.h
@@ -27,16 +27,16 @@ class CORE_EXPORT StringOrDouble final {
StringOrDouble();
bool isNull() const { return m_type == SpecificTypeNone; }
- bool isString() const { return m_type == SpecificTypeString; }
- String getAsString() const;
- void setString(String);
- static StringOrDouble fromString(String);
-
bool isDouble() const { return m_type == SpecificTypeDouble; }
double getAsDouble() const;
void setDouble(double);
static StringOrDouble fromDouble(double);
+ bool isString() const { return m_type == SpecificTypeString; }
+ String getAsString() const;
+ void setString(String);
+ static StringOrDouble fromString(String);
+
StringOrDouble(const StringOrDouble&);
~StringOrDouble();
StringOrDouble& operator=(const StringOrDouble&);
@@ -45,13 +45,13 @@ class CORE_EXPORT StringOrDouble final {
private:
enum SpecificTypes {
SpecificTypeNone,
- SpecificTypeString,
SpecificTypeDouble,
+ SpecificTypeString,
};
SpecificTypes m_type;
- String m_string;
double m_double;
+ String m_string;
friend CORE_EXPORT v8::Local<v8::Value> ToV8(const StringOrDouble&, v8::Local<v8::Object>, v8::Isolate*);
};

Powered by Google App Engine
This is Rietveld 408576698