Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.h

Issue 2742213002: bindings: Make v8_union iterate through its members by type name (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.h
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.h b/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.h
index 9c531731d6f96caf2fe264aad1a9e071d20268f6..66ddb4631b49f532a7378f4f16a751196a5f6901 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.h
+++ b/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.h
@@ -29,16 +29,16 @@ class CORE_EXPORT TestInterfaceOrLong final {
TestInterfaceOrLong();
bool isNull() const { return m_type == SpecificTypeNone; }
- bool isTestInterface() const { return m_type == SpecificTypeTestInterface; }
- TestInterfaceImplementation* getAsTestInterface() const;
- void setTestInterface(TestInterfaceImplementation*);
- static TestInterfaceOrLong fromTestInterface(TestInterfaceImplementation*);
-
bool isLong() const { return m_type == SpecificTypeLong; }
int32_t getAsLong() const;
void setLong(int32_t);
static TestInterfaceOrLong fromLong(int32_t);
+ bool isTestInterface() const { return m_type == SpecificTypeTestInterface; }
+ TestInterfaceImplementation* getAsTestInterface() const;
+ void setTestInterface(TestInterfaceImplementation*);
+ static TestInterfaceOrLong fromTestInterface(TestInterfaceImplementation*);
+
TestInterfaceOrLong(const TestInterfaceOrLong&);
~TestInterfaceOrLong();
TestInterfaceOrLong& operator=(const TestInterfaceOrLong&);
@@ -47,13 +47,13 @@ class CORE_EXPORT TestInterfaceOrLong final {
private:
enum SpecificTypes {
SpecificTypeNone,
- SpecificTypeTestInterface,
SpecificTypeLong,
+ SpecificTypeTestInterface,
};
SpecificTypes m_type;
- Member<TestInterfaceImplementation> m_testInterface;
int32_t m_long;
+ Member<TestInterfaceImplementation> m_testInterface;
friend CORE_EXPORT v8::Local<v8::Value> ToV8(const TestInterfaceOrLong&, v8::Local<v8::Object>, v8::Isolate*);
};

Powered by Google App Engine
This is Rietveld 408576698