Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.h

Issue 2742213002: bindings: Make v8_union iterate through its members by type name (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.h
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.h b/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.h
index eafa3d0849400e8ff3780442f0873dc6cbd89561..a7f8e5cadb43e5cedd8ba3585e84aadc9da8137e 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.h
+++ b/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.h
@@ -29,16 +29,16 @@ class CORE_EXPORT TestInterfaceGarbageCollectedOrString final {
TestInterfaceGarbageCollectedOrString();
bool isNull() const { return m_type == SpecificTypeNone; }
- bool isTestInterfaceGarbageCollected() const { return m_type == SpecificTypeTestInterfaceGarbageCollected; }
- TestInterfaceGarbageCollected* getAsTestInterfaceGarbageCollected() const;
- void setTestInterfaceGarbageCollected(TestInterfaceGarbageCollected*);
- static TestInterfaceGarbageCollectedOrString fromTestInterfaceGarbageCollected(TestInterfaceGarbageCollected*);
-
bool isString() const { return m_type == SpecificTypeString; }
String getAsString() const;
void setString(String);
static TestInterfaceGarbageCollectedOrString fromString(String);
+ bool isTestInterfaceGarbageCollected() const { return m_type == SpecificTypeTestInterfaceGarbageCollected; }
+ TestInterfaceGarbageCollected* getAsTestInterfaceGarbageCollected() const;
+ void setTestInterfaceGarbageCollected(TestInterfaceGarbageCollected*);
+ static TestInterfaceGarbageCollectedOrString fromTestInterfaceGarbageCollected(TestInterfaceGarbageCollected*);
+
TestInterfaceGarbageCollectedOrString(const TestInterfaceGarbageCollectedOrString&);
~TestInterfaceGarbageCollectedOrString();
TestInterfaceGarbageCollectedOrString& operator=(const TestInterfaceGarbageCollectedOrString&);
@@ -47,13 +47,13 @@ class CORE_EXPORT TestInterfaceGarbageCollectedOrString final {
private:
enum SpecificTypes {
SpecificTypeNone,
- SpecificTypeTestInterfaceGarbageCollected,
SpecificTypeString,
+ SpecificTypeTestInterfaceGarbageCollected,
};
SpecificTypes m_type;
- Member<TestInterfaceGarbageCollected> m_testInterfaceGarbageCollected;
String m_string;
+ Member<TestInterfaceGarbageCollected> m_testInterfaceGarbageCollected;
friend CORE_EXPORT v8::Local<v8::Value> ToV8(const TestInterfaceGarbageCollectedOrString&, v8::Local<v8::Object>, v8::Isolate*);
};

Powered by Google App Engine
This is Rietveld 408576698