[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc to ARC.

Converts  ios/chrome/browser/ui/bookmarks:bookmarks_arc to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* automatic rewriter script rewrote "return scoped_foo.autorelease();" to "return scoped_foo = nil;" causing EG test failures

BUG=624363
TEST=None

Initially was failing EG tests, see Notable issues for steps taken.

Review-Url: https://codereview.chromium.org/2741413005
Cr-Commit-Position: refs/heads/master@{#456684}
Committed: https://chromium.googlesource.com/chromium/src/+/7bbaaf780f18e55c5f7055933f557b49cfb8dd90

[stkhapugin, 2017-03-13 15:40:58]

Description was changed from

==========
Reland of  ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* automatic rewriter script rewrote "return scoped_foo.autorelease();" to
"return scoped_foo = nil;" causing EG test failures

BUG=624363
TEST=None
==========

to

==========
Reland of  ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* automatic rewriter script rewrote "return scoped_foo.autorelease();" to
"return scoped_foo = nil;" causing EG test failures

BUG=624363
TEST=None
==========

[stkhapugin, 2017-03-13 15:40:58]

stkhapugin@chromium.org changed reviewers:
+ lpromero@chromium.org

[stkhapugin, 2017-03-13 15:43:51]

PTAL. Sorry I failed to create two patches - the changed files are:

ios/chrome/browser/ui/bookmarks/bookmark_folder_editor_view_controller.mm
ios/chrome/browser/ui/bookmarks/bookmark_folder_table_view_cell.mm

The difference between patches is described in "notable changes"

I originally fixed this issue in a dependent patch instead of this one, which is
why locally tests have been passing for me. Sorry for confusion.

[lpromero, 2017-03-13 16:11:15]

lgtm. Sorry I missed it during the first review :(

https://codereview.chromium.org/2741413005/diff/1/ios/chrome/browser/ui/bookm...
File ios/chrome/browser/ui/bookmarks/BUILD.gn (right):

https://codereview.chromium.org/2741413005/diff/1/ios/chrome/browser/ui/bookm...
ios/chrome/browser/ui/bookmarks/BUILD.gn:5: source_set("bookmarks_arc") {
Is the CL description still accurate?

(Usually, when I reland, I don't mention reland in the title. I add a paragraph
at the end of the description. Because the most important is the change, not the
fact that it's a second attempt.)

[stkhapugin, 2017-03-13 16:41:18]

Description was changed from

==========
Reland of  ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* automatic rewriter script rewrote "return scoped_foo.autorelease();" to
"return scoped_foo = nil;" causing EG test failures

BUG=624363
TEST=None
==========

to

==========
Converts  ios/chrome/browser/ui/bookmarks:bookmarks_arc to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* automatic rewriter script rewrote "return scoped_foo.autorelease();" to
"return scoped_foo = nil;" causing EG test failures

BUG=624363
TEST=None

Initially was failing EG tests, see Notable issues for steps taken.
==========

[stkhapugin, 2017-03-13 16:41:34]

Thanks a lot, and no worries - I missed it too :D

https://codereview.chromium.org/2741413005/diff/1/ios/chrome/browser/ui/bookm...
File ios/chrome/browser/ui/bookmarks/BUILD.gn (right):

https://codereview.chromium.org/2741413005/diff/1/ios/chrome/browser/ui/bookm...
ios/chrome/browser/ui/bookmarks/BUILD.gn:5: source_set("bookmarks_arc") {
On 2017/03/13 16:11:14, lpromero wrote:
> Is the CL description still accurate?
> 
> (Usually, when I reland, I don't mention reland in the title. I add a
paragraph
> at the end of the description. Because the most important is the change, not
the
> fact that it's a second attempt.)

Done.

[stkhapugin, 2017-03-13 16:41:46]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-03-13 16:42:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 18:20:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 18:20:34]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stkhapugin, 2017-03-14 12:49:57]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-03-14 12:50:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 13:26:13]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489495797854820, "parent_rev":
"0fe6bc1c1b65086da86d225ac7dfe9b00a317a1e", "commit_rev":
"7bbaaf780f18e55c5f7055933f557b49cfb8dd90"}

[commit-bot: I haz the power, 2017-03-14 13:26:54]

Description was changed from

==========
Converts  ios/chrome/browser/ui/bookmarks:bookmarks_arc to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* automatic rewriter script rewrote "return scoped_foo.autorelease();" to
"return scoped_foo = nil;" causing EG test failures

BUG=624363
TEST=None

Initially was failing EG tests, see Notable issues for steps taken.
==========

to

==========
Converts  ios/chrome/browser/ui/bookmarks:bookmarks_arc to ARC.

Automatically generated ARCMigrate commit
Notable issues:
* automatic rewriter script rewrote "return scoped_foo.autorelease();" to
"return scoped_foo = nil;" causing EG test failures

BUG=624363
TEST=None

Initially was failing EG tests, see Notable issues for steps taken.

Review-Url: https://codereview.chromium.org/2741413005
Cr-Commit-Position: refs/heads/master@{#456684}
Committed:
https://chromium.googlesource.com/chromium/src/+/7bbaaf780f18e55c5f7055933f55...
==========

[commit-bot: I haz the power, 2017-03-14 13:26:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7bbaaf780f18e55c5f7055933f55...