[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2746473003
Cr-Commit-Position: refs/heads/master@{#459141}
Committed: https://chromium.googlesource.com/chromium/src/+/e1b5abb6552410cef4b2de74624b24a32a3081a2

[stkhapugin, 2017-03-10 14:09:13]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 14:09:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-03-10 15:17:18]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 15:17:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-03-10 15:25:14]

stkhapugin@chromium.org changed reviewers:
+ lpromero@chromium.org

[stkhapugin, 2017-03-10 15:25:15]

PTAL

[lpromero, 2017-03-10 16:06:18]

lgtm

https://codereview.chromium.org/2746473003/diff/60001/ios/chrome/browser/ui/b...
File ios/chrome/browser/ui/bookmarks/bookmark_model_bridge_observer.h (right):

https://codereview.chromium.org/2746473003/diff/60001/ios/chrome/browser/ui/b...
ios/chrome/browser/ui/bookmarks/bookmark_model_bridge_observer.h:73:
BookmarkModel* model_;                      // weak
This can move closer to the semicolon I guess.

https://codereview.chromium.org/2746473003/diff/60001/ios/chrome/browser/ui/b...
File ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm (right):

https://codereview.chromium.org/2746473003/diff/60001/ios/chrome/browser/ui/b...
ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm:190: _promoView =
promoView;
One-liner instead?

[commit-bot: I haz the power, 2017-03-10 16:17:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 16:17:11]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[stkhapugin, 2017-03-10 16:17:20]

Thanks!

https://codereview.chromium.org/2746473003/diff/60001/ios/chrome/browser/ui/b...
File ios/chrome/browser/ui/bookmarks/bookmark_model_bridge_observer.h (right):

https://codereview.chromium.org/2746473003/diff/60001/ios/chrome/browser/ui/b...
ios/chrome/browser/ui/bookmarks/bookmark_model_bridge_observer.h:73:
BookmarkModel* model_;                      // weak
On 2017/03/10 16:06:18, lpromero wrote:
> This can move closer to the semicolon I guess.

Done.

https://codereview.chromium.org/2746473003/diff/60001/ios/chrome/browser/ui/b...
File ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm (right):

https://codereview.chromium.org/2746473003/diff/60001/ios/chrome/browser/ui/b...
ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm:190: _promoView =
promoView;
On 2017/03/10 16:06:18, lpromero wrote:
> One-liner instead?

Not sure if you are proposing to put 

BookmarkPromoView* promoView =
        [[BookmarkPromoView alloc] initWithFrame:frame];

on one line (this doesn't fit), or use _promoView = ...; and not introduce the
intermediary reference (this doesn't work because the ivar is weak and the
object will be immediately deallocated)

[lpromero, 2017-03-10 16:19:59]

https://codereview.chromium.org/2746473003/diff/60001/ios/chrome/browser/ui/b...
File ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm (right):

https://codereview.chromium.org/2746473003/diff/60001/ios/chrome/browser/ui/b...
ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm:190: _promoView =
promoView;
On 2017/03/10 16:17:19, stkhapugin wrote:
> On 2017/03/10 16:06:18, lpromero wrote:
> > One-liner instead?
> 
> Not sure if you are proposing to put 
> 
> BookmarkPromoView* promoView =
>         [[BookmarkPromoView alloc] initWithFrame:frame];
> 
> on one line (this doesn't fit), or use _promoView = ...; and not introduce the
> intermediary reference (this doesn't work because the ivar is weak and the
> object will be immediately deallocated)

That was the second. Thanks for the explanation!

[stkhapugin, 2017-03-10 16:32:25]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 16:34:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-03-14 15:06:01]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-03-14 15:06:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2746473003/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-14 15:06:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 16:09:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 16:09:55]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[stkhapugin, 2017-03-15 15:37:59]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-03-15 15:37:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2746473003/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-15 15:38:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 16:19:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 16:19:58]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stkhapugin, 2017-03-22 15:32:11]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-03-22 15:32:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2746473003/#ps160001
(title: "fix test")

[commit-bot: I haz the power, 2017-03-22 15:32:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 16:21:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 16:21:16]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stkhapugin, 2017-03-22 16:21:43]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-03-22 16:22:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 18:34:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 18:34:56]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stkhapugin, 2017-03-23 15:45:05]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-03-23 15:45:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 16:28:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 16:28:28]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stkhapugin, 2017-03-23 16:44:48]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-03-23 16:45:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 17:03:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 17:03:48]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stkhapugin, 2017-03-23 17:12:43]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-03-23 17:13:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 18:05:00]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1490289163300170,
"parent_rev": "3a25306be22f2ddbe25d0c10929b87d8f9c9ace9", "commit_rev":
"e1b5abb6552410cef4b2de74624b24a32a3081a2"}

[commit-bot: I haz the power, 2017-03-23 18:05:51]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2746473003
Cr-Commit-Position: refs/heads/master@{#459141}
Committed:
https://chromium.googlesource.com/chromium/src/+/e1b5abb6552410cef4b2de74624b...
==========

[commit-bot: I haz the power, 2017-03-23 18:05:53]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/e1b5abb6552410cef4b2de74624b...