[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc to ARC.

[ObjC ARC] Converts a part of ios/chrome/browser/ui/bookmarks:bookmarks to ARC.

Automatically generated ARCMigrate commit (after manually splitting the target).

Converted a relevant unit test alongside this to prevent fiddling with BOOL GetPositionCache(bookmarks::BookmarkModel* model, BookmarkMenuItem** item,  CGFloat* position);
which has an out paramteter |item| that is __autoreleasing in ARC.

Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2737793003
Cr-Commit-Position: refs/heads/master@{#456054}
Committed: https://chromium.googlesource.com/chromium/src/+/d1b61106131df8a2eca7d0a71ea026d6e3707680

[stkhapugin, 2017-03-08 14:55:42]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 14:55:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 15:04:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 15:04:24]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[stkhapugin, 2017-03-08 15:13:56]

[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:unit_tests_arc to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

[stkhapugin, 2017-03-08 15:13:57]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 15:14:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-03-08 15:21:22]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts a part of ios/chrome/browser/ui/bookmarks:bookmarks to ARC.

Automatically generated ARCMigrate commit (after manually splitting the target).

Converted a relevant unit test alongside this to prevent fiddling with BOOL
GetPositionCache(bookmarks::BookmarkModel* model, BookmarkMenuItem** item, 
CGFloat* position);
which has an out paramteter |item| that is __autoreleasing in ARC.

Notable issues:None
BUG=624363
TEST=None
==========

[stkhapugin, 2017-03-08 16:37:44]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 16:38:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-03-08 17:19:22]

stkhapugin@chromium.org changed reviewers:
+ noyau@chromium.org

[stkhapugin, 2017-03-08 17:19:23]

PTAL

[commit-bot: I haz the power, 2017-03-08 19:06:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 19:06:26]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-03-10 10:49:06]

stkhapugin@chromium.org changed reviewers:
+ lpromero@chromium.org
- noyau@chromium.org

[stkhapugin, 2017-03-10 10:49:07]

-noyau +lpromero

PTAL :)

[lpromero, 2017-03-10 11:45:19]

lgtm

https://codereview.chromium.org/2737793003/diff/80001/ios/chrome/browser/ui/b...
File ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm
(right):

https://codereview.chromium.org/2737793003/diff/80001/ios/chrome/browser/ui/b...
ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm:10: 
Remove empty line.

[stkhapugin, 2017-03-10 12:16:29]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-03-10 12:16:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2737793003/#ps100001
(title: "empty line")

[stkhapugin, 2017-03-10 12:16:38]

Thank you!

https://codereview.chromium.org/2737793003/diff/80001/ios/chrome/browser/ui/b...
File ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm
(right):

https://codereview.chromium.org/2737793003/diff/80001/ios/chrome/browser/ui/b...
ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm:10: 
On 2017/03/10 11:45:18, lpromero wrote:
> Remove empty line.

Done.

[commit-bot: I haz the power, 2017-03-10 12:16:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 14:15:58]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1489148189919470,
"parent_rev": "160af85b762e4a581ab6b53e079f261e901d07c6", "commit_rev":
"d1b61106131df8a2eca7d0a71ea026d6e3707680"}

[commit-bot: I haz the power, 2017-03-10 14:16:41]

Description was changed from

==========
[ObjC ARC] Converts a part of ios/chrome/browser/ui/bookmarks:bookmarks to ARC.

Automatically generated ARCMigrate commit (after manually splitting the target).

Converted a relevant unit test alongside this to prevent fiddling with BOOL
GetPositionCache(bookmarks::BookmarkModel* model, BookmarkMenuItem** item, 
CGFloat* position);
which has an out paramteter |item| that is __autoreleasing in ARC.

Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts a part of ios/chrome/browser/ui/bookmarks:bookmarks to ARC.

Automatically generated ARCMigrate commit (after manually splitting the target).

Converted a relevant unit test alongside this to prevent fiddling with BOOL
GetPositionCache(bookmarks::BookmarkModel* model, BookmarkMenuItem** item, 
CGFloat* position);
which has an out paramteter |item| that is __autoreleasing in ARC.

Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2737793003
Cr-Commit-Position: refs/heads/master@{#456054}
Committed:
https://chromium.googlesource.com/chromium/src/+/d1b61106131df8a2eca7d0a71ea0...
==========

[commit-bot: I haz the power, 2017-03-10 14:16:43]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/d1b61106131df8a2eca7d0a71ea0...