Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: ios/chrome/browser/ui/bookmarks/BUILD.gn

Issue 2737793003: [ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc to ARC. (Closed)
Patch Set: empty line Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/bookmarks/BUILD.gn
diff --git a/ios/chrome/browser/ui/bookmarks/BUILD.gn b/ios/chrome/browser/ui/bookmarks/BUILD.gn
index 5887084c003e5290dbfb045815511ec9f9de2a11..bbe8c4ec94339b3798daa4c686d5df55945fb5fb 100644
--- a/ios/chrome/browser/ui/bookmarks/BUILD.gn
+++ b/ios/chrome/browser/ui/bookmarks/BUILD.gn
@@ -2,6 +2,75 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+source_set("bookmarks_arc") {
+ configs += [ "//build/config/compiler:enable_arc" ]
+ sources = [
+ "bookmark_home_handset_view_controller.h",
+ "bookmark_home_handset_view_controller.mm",
+ "bookmark_home_tablet_ntp_controller.h",
+ "bookmark_home_tablet_ntp_controller.mm",
+ "bookmark_utils_ios.h",
+ "bookmark_utils_ios.mm",
+ ]
+ deps = [
+ ":resources",
+ "//base",
+ "//base:i18n",
+ "//components/bookmarks/browser",
+ "//components/favicon/core",
+ "//components/favicon_base",
+ "//components/pref_registry",
+ "//components/prefs",
+ "//components/query_parser",
+ "//components/signin/core/browser",
+ "//components/strings",
+ "//components/undo",
+ "//components/url_formatter",
+ "//google_apis",
+ "//ios/chrome/app/strings",
+ "//ios/chrome/app/theme",
+ "//ios/chrome/browser",
+ "//ios/chrome/browser/bookmarks",
+ "//ios/chrome/browser/bookmarks:bookmarks_utils",
+ "//ios/chrome/browser/browser_state",
+ "//ios/chrome/browser/favicon",
+ "//ios/chrome/browser/metrics:metrics_internal",
+ "//ios/chrome/browser/signin",
+ "//ios/chrome/browser/tabs",
+ "//ios/chrome/browser/ui",
+ "//ios/chrome/browser/ui/alert_coordinator",
+ "//ios/chrome/browser/ui/bookmarks/bars",
+ "//ios/chrome/browser/ui/bookmarks/cells",
+ "//ios/chrome/browser/ui/collection_view",
+ "//ios/chrome/browser/ui/collection_view/cells",
+ "//ios/chrome/browser/ui/colors",
+ "//ios/chrome/browser/ui/commands",
+ "//ios/chrome/browser/ui/icons",
+ "//ios/chrome/browser/ui/keyboard",
+ "//ios/chrome/browser/ui/material_components",
+ "//ios/chrome/browser/ui/ntp",
+ "//ios/chrome/browser/undo",
+ "//ios/public/provider/chrome/browser",
+ "//ios/public/provider/chrome/browser/ui",
+ "//ios/third_party/material_components_ios",
+ "//ios/third_party/material_roboto_font_loader_ios",
+ "//ios/web",
+ "//skia",
+ "//ui/base",
+ "//ui/gfx",
+ "//url",
+ ]
+ allow_circular_includes_from = [
+ "//ios/chrome/browser/ui/bookmarks/bars",
+ "//ios/chrome/browser/ui/bookmarks/cells",
+ ]
+ libs = [
+ "CoreGraphics.framework",
+ "QuartzCore.framework",
+ "UIKit.framework",
+ ]
+}
+
source_set("bookmarks") {
sources = [
"bookmark_collection_cells.h",
@@ -26,11 +95,7 @@ source_set("bookmarks") {
"bookmark_folder_table_view_cell.mm",
"bookmark_folder_view_controller.h",
"bookmark_folder_view_controller.mm",
- "bookmark_home_handset_view_controller.h",
- "bookmark_home_handset_view_controller.mm",
"bookmark_home_primary_view.h",
- "bookmark_home_tablet_ntp_controller.h",
- "bookmark_home_tablet_ntp_controller.mm",
"bookmark_home_view_controller.h",
"bookmark_home_view_controller.mm",
"bookmark_home_waiting_view.h",
@@ -55,8 +120,6 @@ source_set("bookmarks") {
"bookmark_promo_cell.mm",
"bookmark_promo_controller.h",
"bookmark_promo_controller.mm",
- "bookmark_utils_ios.h",
- "bookmark_utils_ios.mm",
"undo_manager_bridge_observer.h",
"undo_manager_bridge_observer.mm",
"undo_manager_wrapper.h",
@@ -110,9 +173,13 @@ source_set("bookmarks") {
"//ui/gfx",
"//url",
]
+ public_deps = [
+ ":bookmarks_arc",
+ ]
allow_circular_includes_from = [
"//ios/chrome/browser/ui/bookmarks/bars",
"//ios/chrome/browser/ui/bookmarks/cells",
+ ":bookmarks_arc",
]
libs = [
"CoreGraphics.framework",
@@ -121,13 +188,34 @@ source_set("bookmarks") {
]
}
+source_set("unit_tests_arc") {
+ configs += [ "//build/config/compiler:enable_arc" ]
+ testonly = true
+ sources = [
+ "bookmark_utils_ios_unittest.mm",
+ ]
+ deps = [
+ ":bookmarks",
+ "//base",
+ "//components/bookmarks/browser",
+ "//components/bookmarks/test",
+ "//ios/chrome/browser",
+ "//ios/chrome/browser/bookmarks",
+ "//ios/chrome/browser/browser_state:test_support",
+ "//ios/web:test_support",
+ "//testing/gtest",
+ ]
+}
+
source_set("unit_tests") {
testonly = true
sources = [
"bookmark_home_view_controller_unittest.mm",
"bookmark_ios_unittest.mm",
"bookmark_position_cache_unittest.mm",
- "bookmark_utils_ios_unittest.mm",
+ ]
+ public_deps = [
+ ":unit_tests_arc",
]
deps = [
":bookmarks",
« no previous file with comments | « no previous file | ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698