Add Active Directory login UI tests

Add Active Directory login UI tests

BUG=682421, 698731
TEST=ActiveDirectoryLoginTest.*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

TBR=pbond@chromium.org,emaxx@chromium.org,bartfab@chromium.org,courage@chromium.org,juliatuttle@chromium.org,stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2737733003
Cr-Commit-Position: refs/heads/master@{#458786}
Committed: https://chromium.googlesource.com/chromium/src/+/8de9932fb6a6364f688b9966f08609d30d124cdf

[Roman Sorokin (ftl), 2017-03-07 14:17:58]

Description was changed from

==========
Add Active Directory login UI tests

BUG=682421,698731
TEST=ActiveDirectoryLoginTest.*
==========

to

==========
Add Active Directory login UI tests

BUG=682421,698731
TEST=ActiveDirectoryLoginTest.*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Roman Sorokin (ftl), 2017-03-07 14:18:48]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 14:19:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roman Sorokin (ftl), 2017-03-07 14:20:46]

rsorokin@chromium.org changed reviewers:
+ achuith@chromium.org

[Roman Sorokin (ftl), 2017-03-07 14:20:47]

Hey Achuith, PTAL.

[Roman Sorokin (ftl), 2017-03-07 14:25:09]

rsorokin@chromium.org changed reviewers:
+ tnagel@chromium.org

[Roman Sorokin (ftl), 2017-03-07 14:25:10]

Hey Thiemo, PTAL.

[achuithb, 2017-03-07 15:07:04]

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/helper.h (right):

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/helper.h:47: enum ActiveDirectoryErrorState {
Can you make this an enum class since you're touching/moving this?

Also, is there a better place to put this? We don't want login/helper.h to be a
dumping ground for random unrelated things.

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/login_browsertest.cc (right):

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_browsertest.cc:193: #define JS_AD_PREFIX
"document.querySelector('#offline-ad-auth /deep/ "
Hmm, pretty sure new macros are banned.

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_browsertest.cc:204: class
ActiveDirectoryLoginTest : public LoginManagerTest {
This should also be in the anonymous namespace - why give the linker additional
work?

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_browsertest.cc:206:
ActiveDirectoryLoginTest()
Newlines between methods please. This is very dense.

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_browsertest.cc:232:
js_checker().ExpectTrue("document.querySelector('#signin-frame').hidden");
You can replace these with JSExpect() (switch the polarity of the ExpectFalse
statements)

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_browsertest.cc:240:
js_checker().ExpectFalse(kAdPasswordInput + hidden);
I think a method like JSElement(const std::string& element_id) 
with JSElement("#userInput"), JSElement("#passwordInput"), etc might work
better?

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_browsertest.cc:296: };
DISALLOW_COPY_AND_ASSIGN

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_browsertest.cc:398:
IN_PROC_BROWSER_TEST_F(ActiveDirectoryLoginTest, PRE_LoginSuccess) {
Test comments for all functions please

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_browsertest.cc:413: //
TestSystemTrayIsVisible();
Sad

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/set...
File chrome/browser/chromeos/settings/stub_install_attributes.h (right):

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/set...
chrome/browser/chromeos/settings/stub_install_attributes.h:30: void
SetActiveDirectoryEnterprise(const std::string& realm);
Function comment please.

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/set...
chrome/browser/chromeos/settings/stub_install_attributes.h:52: static
ScopedStubInstallAttributes CreateActiveDirectoryEnterprise(
Function comment please

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:1123:
invalidateAd: function(username, errorState) {
Where is this used in the test?

[commit-bot: I haz the power, 2017-03-07 15:10:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 15:10:36]

Dry run: This issue passed the CQ dry run.

[Roman Sorokin (ftl), 2017-03-07 15:18:21]

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/helper.h (right):

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/helper.h:47: enum ActiveDirectoryErrorState {
On 2017/03/07 15:07:03, achuithb wrote:
> Can you make this an enum class since you're touching/moving this?
> 
> Also, is there a better place to put this? We don't want login/helper.h to be
a
> dumping ground for random unrelated things.

I'm not sure, it's needed in both enrollment_screen_handler.cc and
gaia_screen_handler.cc. Should I create a new *.h file?

[achuithb, 2017-03-07 15:28:50]

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/helper.h (right):

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/helper.h:47: enum ActiveDirectoryErrorState {
On 2017/03/07 15:18:20, Roman Sorokin wrote:
> On 2017/03/07 15:07:03, achuithb wrote:
> > Can you make this an enum class since you're touching/moving this?
> > 
> > Also, is there a better place to put this? We don't want login/helper.h to
be
> a
> > dumping ground for random unrelated things.
> 
> I'm not sure, it's needed in both enrollment_screen_handler.cc and
> gaia_screen_handler.cc. Should I create a new *.h file?

How about moving it to enrollment_screen_handler.h?

[Roman Sorokin (ftl), 2017-03-07 16:32:05]

Thanks, Achuith! PTAL

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/helper.h (right):

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/helper.h:47: enum ActiveDirectoryErrorState {
On 2017/03/07 15:28:50, achuithb wrote:
> On 2017/03/07 15:18:20, Roman Sorokin wrote:
> > On 2017/03/07 15:07:03, achuithb wrote:
> > > Can you make this an enum class since you're touching/moving this?
> > > 
> > > Also, is there a better place to put this? We don't want login/helper.h to
> be
> > a
> > > dumping ground for random unrelated things.
> > 
> > I'm not sure, it's needed in both enrollment_screen_handler.cc and
> > gaia_screen_handler.cc. Should I create a new *.h file?
> 
> How about moving it to enrollment_screen_handler.h?

That way gaia_screen_handler.cc does not see it

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/login_browsertest.cc (right):

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_browsertest.cc:193: #define JS_AD_PREFIX
"document.querySelector('#offline-ad-auth /deep/ "
On 2017/03/07 15:07:03, achuithb wrote:
> Hmm, pretty sure new macros are banned.
Done.

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_browsertest.cc:204: class
ActiveDirectoryLoginTest : public LoginManagerTest {
On 2017/03/07 15:07:03, achuithb wrote:
> This should also be in the anonymous namespace - why give the linker
additional
> work?

Done. My bad - I put anonymous namespace inside anonymous namespace

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_browsertest.cc:206:
ActiveDirectoryLoginTest()
On 2017/03/07 15:07:03, achuithb wrote:
> Newlines between methods please. This is very dense.

Done.

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_browsertest.cc:232:
js_checker().ExpectTrue("document.querySelector('#signin-frame').hidden");
On 2017/03/07 15:07:03, achuithb wrote:
> You can replace these with JSExpect() (switch the polarity of the ExpectFalse
> statements)

Done.

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_browsertest.cc:240:
js_checker().ExpectFalse(kAdPasswordInput + hidden);
On 2017/03/07 15:07:03, achuithb wrote:
> I think a method like JSElement(const std::string& element_id) 
> with JSElement("#userInput"), JSElement("#passwordInput"), etc might work
> better?

Done.

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_browsertest.cc:296: };
On 2017/03/07 15:07:03, achuithb wrote:
> DISALLOW_COPY_AND_ASSIGN

Done.

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_browsertest.cc:398:
IN_PROC_BROWSER_TEST_F(ActiveDirectoryLoginTest, PRE_LoginSuccess) {
On 2017/03/07 15:07:03, achuithb wrote:
> Test comments for all functions please

Done.

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_browsertest.cc:413: //
TestSystemTrayIsVisible();
On 2017/03/07 15:07:03, achuithb wrote:
> Sad

Acknowledged.

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/set...
File chrome/browser/chromeos/settings/stub_install_attributes.h (right):

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/set...
chrome/browser/chromeos/settings/stub_install_attributes.h:30: void
SetActiveDirectoryEnterprise(const std::string& realm);
On 2017/03/07 15:07:04, achuithb wrote:
> Function comment please.

Done.

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/set...
chrome/browser/chromeos/settings/stub_install_attributes.h:52: static
ScopedStubInstallAttributes CreateActiveDirectoryEnterprise(
On 2017/03/07 15:07:04, achuithb wrote:
> Function comment please

Done.

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:1123:
invalidateAd: function(username, errorState) {
On 2017/03/07 15:07:04, achuithb wrote:
> Where is this used in the test?

GaiaScreenHandler passes it depending on answer from FakeAuthPolicyClient

[achuithb, 2017-03-09 10:34:06]

lgtm

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/helper.h (right):

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/helper.h:47: enum ActiveDirectoryErrorState {
On 2017/03/07 16:32:05, Roman Sorokin wrote:
> On 2017/03/07 15:28:50, achuithb wrote:
> > On 2017/03/07 15:18:20, Roman Sorokin wrote:
> > > On 2017/03/07 15:07:03, achuithb wrote:
> > > > Can you make this an enum class since you're touching/moving this?
> > > > 
> > > > Also, is there a better place to put this? We don't want login/helper.h
to
> > be
> > > a
> > > > dumping ground for random unrelated things.
> > > 
> > > I'm not sure, it's needed in both enrollment_screen_handler.cc and
> > > gaia_screen_handler.cc. Should I create a new *.h file?
> > 
> > How about moving it to enrollment_screen_handler.h?
> 
> That way gaia_screen_handler.cc does not see it

Why not include enrollment_screen_handler.h in gaia_screen_handler.cc? Including
some extra stuff in a cc file shouldn't be a big problem.

https://codereview.chromium.org/2737733003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/login_browsertest.cc (right):

https://codereview.chromium.org/2737733003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/login_browsertest.cc:235: const std::string
hidden(".hidden");
I don't think there's any value to this temporary. It's inconsistent with the
rest of the code

https://codereview.chromium.org/2737733003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/login_browsertest.cc:288: std::string
JSElement(const std::string& element_id) {
nit: also add a comment for this.

[Thiemo Nagel, 2017-03-21 13:44:22]

https://codereview.chromium.org/2737733003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/helper.h (right):

https://codereview.chromium.org/2737733003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/helper.h:48: NONE = 0,
Nit: "SUCCESS" might be easier to understand?

https://codereview.chromium.org/2737733003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/settings/stub_install_attributes.h (right):

https://codereview.chromium.org/2737733003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/settings/stub_install_attributes.h:28: void
SetEnterprise(const std::string& domain, const std::string& device_id);
Nit: Maybe rename to something with Cloud to make it clearer and to keep
symmetry with the AD counterpart?

What would you think about:
SetConsumerOwned()
SetCloudManaged()
SetActiveDirectoryManaged()

https://codereview.chromium.org/2737733003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/settings/stub_install_attributes.h:32: void
SetActiveDirectoryEnterprise(const std::string& realm);
For better or worse, AD install attributes contain device_id.  Therefore I think
it would make sense to add that here.

[Roman Sorokin (ftl), 2017-03-21 13:51:41]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 13:52:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 14:52:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 14:52:08]

Dry run: This issue passed the CQ dry run.

[Roman Sorokin (ftl), 2017-03-22 13:18:19]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 13:18:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 13:21:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 13:21:15]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Roman Sorokin (ftl), 2017-03-22 13:28:33]

The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 13:28:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roman Sorokin (ftl), 2017-03-22 15:19:25]

Thanks, Thiemo! PTAL.

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/helper.h (right):

https://codereview.chromium.org/2737733003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/helper.h:47: enum ActiveDirectoryErrorState {
On 2017/03/09 10:34:06, achuithb wrote:
> On 2017/03/07 16:32:05, Roman Sorokin wrote:
> > On 2017/03/07 15:28:50, achuithb wrote:
> > > On 2017/03/07 15:18:20, Roman Sorokin wrote:
> > > > On 2017/03/07 15:07:03, achuithb wrote:
> > > > > Can you make this an enum class since you're touching/moving this?
> > > > > 
> > > > > Also, is there a better place to put this? We don't want
login/helper.h
> to
> > > be
> > > > a
> > > > > dumping ground for random unrelated things.
> > > > 
> > > > I'm not sure, it's needed in both enrollment_screen_handler.cc and
> > > > gaia_screen_handler.cc. Should I create a new *.h file?
> > > 
> > > How about moving it to enrollment_screen_handler.h?
> > 
> > That way gaia_screen_handler.cc does not see it
> 
> Why not include enrollment_screen_handler.h in gaia_screen_handler.cc?
Including
> some extra stuff in a cc file shouldn't be a big problem.

Done.

https://codereview.chromium.org/2737733003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/helper.h (right):

https://codereview.chromium.org/2737733003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/helper.h:48: NONE = 0,
On 2017/03/21 13:44:22, Thiemo Nagel wrote:
> Nit: "SUCCESS" might be easier to understand?

I'm not sure it's less confusing. We don't have any 'success' state. Just the
default NONE error one.

https://codereview.chromium.org/2737733003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/login_browsertest.cc (right):

https://codereview.chromium.org/2737733003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/login_browsertest.cc:235: const std::string
hidden(".hidden");
On 2017/03/09 10:34:06, achuithb wrote:
> I don't think there's any value to this temporary. It's inconsistent with the
> rest of the code

Done.

https://codereview.chromium.org/2737733003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/login_browsertest.cc:288: std::string
JSElement(const std::string& element_id) {
On 2017/03/09 10:34:06, achuithb wrote:
> nit: also add a comment for this.

Done.

https://codereview.chromium.org/2737733003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/settings/stub_install_attributes.h (right):

https://codereview.chromium.org/2737733003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/settings/stub_install_attributes.h:28: void
SetEnterprise(const std::string& domain, const std::string& device_id);
On 2017/03/21 13:44:22, Thiemo Nagel wrote:
> Nit: Maybe rename to something with Cloud to make it clearer and to keep
> symmetry with the AD counterpart?
> 
> What would you think about:
> SetConsumerOwned()
> SetCloudManaged()
> SetActiveDirectoryManaged()

Make sense!

https://codereview.chromium.org/2737733003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/settings/stub_install_attributes.h:32: void
SetActiveDirectoryEnterprise(const std::string& realm);
On 2017/03/21 13:44:22, Thiemo Nagel wrote:
> For better or worse, AD install attributes contain device_id.  Therefore I
think
> it would make sense to add that here.

Done.

[commit-bot: I haz the power, 2017-03-22 16:15:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 16:15:11]

Dry run: This issue passed the CQ dry run.

[Thiemo Nagel, 2017-03-22 16:38:26]

lgtm */policy/*

[Roman Sorokin (ftl), 2017-03-22 16:56:30]

Description was changed from

==========
Add Active Directory login UI tests

BUG=682421,698731
TEST=ActiveDirectoryLoginTest.*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add Active Directory login UI tests

BUG=682421,698731
TEST=ActiveDirectoryLoginTest.*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

TBR=pbond@chromium.org,emaxx@chromium.org,bartfab@chromium.org,courage@chromi...
==========

[Roman Sorokin (ftl), 2017-03-22 16:57:50]

Thanks!

Putting owners for files with mechanical renamings in TBR.

[Roman Sorokin (ftl), 2017-03-22 16:58:09]

The CQ bit was checked by rsorokin@chromium.org

[Roman Sorokin (ftl), 2017-03-22 16:58:10]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2737733003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-22 16:58:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 17:11:32]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490201889593650,
"parent_rev": "5652815761b6981d2f603ca8f5a1ed14ef923c6d", "commit_rev":
"8de9932fb6a6364f688b9966f08609d30d124cdf"}

[commit-bot: I haz the power, 2017-03-22 17:12:41]

Description was changed from

==========
Add Active Directory login UI tests

BUG=682421,698731
TEST=ActiveDirectoryLoginTest.*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

TBR=pbond@chromium.org,emaxx@chromium.org,bartfab@chromium.org,courage@chromi...
==========

to

==========
Add Active Directory login UI tests

BUG=682421,698731
TEST=ActiveDirectoryLoginTest.*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

TBR=pbond@chromium.org,emaxx@chromium.org,bartfab@chromium.org,courage@chromi...

Review-Url: https://codereview.chromium.org/2737733003
Cr-Commit-Position: refs/heads/master@{#458786}
Committed:
https://chromium.googlesource.com/chromium/src/+/8de9932fb6a6364f688b9966f086...
==========

[commit-bot: I haz the power, 2017-03-22 17:12:43]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8de9932fb6a6364f688b9966f086...