Add Active Directory login UI tests

chrome/browser/chromeos/login/helper.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file contains helper functions used by Chromium OS login.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_HELPER_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_HELPER_H_
 
 #include <string>
@@ skipping 24 matching lines @@
 // |size| is not empty. Otherwise the whole monitor is occupied.
 gfx::Rect CalculateScreenBounds(const gfx::Size& size);
 
 // Returns the size of user image required for proper display under current DPI.
 int GetCurrentUserImageSize();
 
 // Define the constants in |login| namespace to avoid potential
 // conflict with other chromeos components.
 namespace login {
 
+// Possible error states of the Active Directory screen. Must be in the same
+// order as ACTIVE_DIRECTORY_ERROR_STATE enum values.
+enum ActiveDirectoryErrorState {

[achuithb, 2017/03/07 15:07:03]

Can you make this an enum class since you're touching/moving this?

Also, is there a better place to put this? We don't want login/helper.h to be a
dumping ground for random unrelated things.

[Roman Sorokin (ftl), 2017/03/07 15:18:20]

I'm not sure, it's needed in both enrollment_screen_handler.cc and
gaia_screen_handler.cc. Should I create a new *.h file?

[achuithb, 2017/03/07 15:28:50]

How about moving it to enrollment_screen_handler.h?

[Roman Sorokin (ftl), 2017/03/07 16:32:05]

That way gaia_screen_handler.cc does not see it

[achuithb, 2017/03/09 10:34:06]

Why not include enrollment_screen_handler.h in gaia_screen_handler.cc? Including
some extra stuff in a cc file shouldn't be a big problem.

[Roman Sorokin (ftl), 2017/03/22 15:19:25]

Done.

+  ERROR_STATE_NONE = 0,
+  ERROR_STATE_MACHINE_NAME_INVALID = 1,
+  ERROR_STATE_MACHINE_NAME_TOO_LONG = 2,
+  ERROR_STATE_BAD_USERNAME = 3,
+  ERROR_STATE_BAD_PASSWORD = 4,
+};
+
 // Maximum size of user image, in which it should be saved to be properly
 // displayed under all possible DPI values.
 const int kMaxUserImageSize = 512;
 
 // Returns true if lock/login should scroll user pods into view itself when
 // virtual keyboard is shown and disable vk overscroll.
 bool LoginScrollIntoViewEnabled();
 
 // A helper class for easily mocking out Network*Handler calls for tests.
 class NetworkStateHelper {
@@ skipping 57 matching lines @@
 // Returns file descriptor of a pipe, open for reading. Pipe keeps the passed
 // data.
 void GetPipeReadEnd(const std::string& data,
                     const OnPipeReadyCallback& callback);
 
 }  // namespace login
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_HELPER_H_