chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc - Issue 2737733003: Add Active Directory login UI tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc

Issue 2737733003: Add Active Directory login UI tests (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc ('k') | chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc

diff --git a/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc b/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc

index 4a71583f67a7c70da3e747aa06693e467f7aacde..f86140ac688edda5a1fbba8797c59b00167dddf6 100644

--- a/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc

+++ b/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc

@@ -161,7 +161,7 @@ class EPKChallengeKeyTestBase : public BrowserWithTestWindowTest {

ON_CALL(mock_attestation_flow_, GetCertificate(_, _, _, _, _))

.WillByDefault(Invoke(GetCertificateCallbackTrue));

- stub_install_attributes_.SetEnterprise("google.com", "device_id");

+ stub_install_attributes_.SetCloudManaged("google.com", "device_id");

settings_helper_.ReplaceProvider(chromeos::kDeviceAttestationEnabled);

settings_helper_.SetBoolean(chromeos::kDeviceAttestationEnabled, true);

@@ -273,7 +273,7 @@ class EPKChallengeMachineKeyTest : public EPKChallengeKeyTestBase {

};

TEST_F(EPKChallengeMachineKeyTest, NonEnterpriseDevice) {

- stub_install_attributes_.SetConsumer();

+ stub_install_attributes_.SetConsumerOwned();

EXPECT_EQ(EPKPChallengeMachineKey::kNonEnterpriseDeviceError,

RunFunctionAndReturnError(func_.get(), CreateArgs(), browser()));

@@ -492,7 +492,7 @@ TEST_F(EPKChallengeUserKeyTest, KeyNotRegistered) {

}

TEST_F(EPKChallengeUserKeyTest, PersonalDevice) {

- stub_install_attributes_.SetConsumer();

+ stub_install_attributes_.SetConsumerOwned();

// Currently personal devices are not supported.

EXPECT_EQ(GetCertificateError(kUserRejected),