Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3269)

Unified Diff: chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

Issue 2737733003: Add Active Directory login UI tests (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
index d847e2571c81cb0f2cbdebe56ab3fb9c4f29fa07..94111364cbd001849bfaf055d7de80f6e15d1328 100644
--- a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
@@ -28,6 +28,7 @@
#include "chrome/browser/chromeos/profiles/profile_helper.h"
#include "chrome/browser/chromeos/settings/cros_settings.h"
#include "chrome/browser/io_thread.h"
+#include "chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h"
#include "chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h"
#include "chrome/browser/ui/webui/signin/signin_utils.h"
#include "chrome/common/channel_info.h"
@@ -558,9 +559,12 @@ void GaiaScreenHandler::DoAdAuth(
break;
case authpolicy::ERROR_PARSE_UPN_FAILED:
case authpolicy::ERROR_BAD_USER_NAME:
- case authpolicy::ERROR_BAD_PASSWORD:
- CallJS("invalidateAd", username);
+ CallJS("invalidateAd", username,
+ static_cast<int>(ActiveDirectoryErrorState::BAD_USERNAME));
return;
+ case authpolicy::ERROR_BAD_PASSWORD:
+ CallJS("invalidateAd", username,
+ static_cast<int>(ActiveDirectoryErrorState::BAD_PASSWORD));
case authpolicy::ERROR_UNKNOWN:
case authpolicy::ERROR_DBUS_FAILURE:
case authpolicy::ERROR_CANNOT_RESOLVE_KDC:

Powered by Google App Engine
This is Rietveld 408576698