[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2737603007
Cr-Commit-Position: refs/heads/master@{#456064}
Committed: https://chromium.googlesource.com/chromium/src/+/dfc151cf408ffc92bfdc1d40f06487f8a256bc0a

[stkhapugin, 2017-03-08 17:55:22]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 17:55:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-03-08 18:08:14]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 18:08:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 18:17:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 18:17:25]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[stkhapugin, 2017-03-09 14:41:10]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 14:41:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 15:37:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 15:37:30]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-03-10 10:47:09]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 10:47:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-03-10 10:47:41]

stkhapugin@chromium.org changed reviewers:
+ lpromero@chromium.org

[stkhapugin, 2017-03-10 10:47:42]

ptal

[commit-bot: I haz the power, 2017-03-10 10:50:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 10:50:46]

Dry run: This issue passed the CQ dry run.

[lpromero, 2017-03-10 12:08:45]

lgtm

https://codereview.chromium.org/2737603007/diff/40001/ios/chrome/browser/ui/b...
File ios/chrome/browser/ui/bookmarks/BUILD.gn (right):

https://codereview.chromium.org/2737603007/diff/40001/ios/chrome/browser/ui/b...
ios/chrome/browser/ui/bookmarks/BUILD.gn:5: source_set("bookmarks_arc_2") {
I didn't get why the sources files are not just added to bookmarks_arc? Is it
just because of the automation? Do you want to merge both arc targets in a
follow-up CL?

[stkhapugin, 2017-03-10 14:22:40]

Thanks!

https://codereview.chromium.org/2737603007/diff/40001/ios/chrome/browser/ui/b...
File ios/chrome/browser/ui/bookmarks/BUILD.gn (right):

https://codereview.chromium.org/2737603007/diff/40001/ios/chrome/browser/ui/b...
ios/chrome/browser/ui/bookmarks/BUILD.gn:5: source_set("bookmarks_arc_2") {
On 2017/03/10 12:08:44, lpromero wrote:
> I didn't get why the sources files are not just added to bookmarks_arc? Is it
> just because of the automation? Do you want to merge both arc targets in a
> follow-up CL?

Yes, sorry, I forgot to merge this. Done.

[stkhapugin, 2017-03-10 14:22:52]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-03-10 14:22:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2737603007/#ps60001
(title: "merged targets in gn")

[commit-bot: I haz the power, 2017-03-10 14:23:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 15:26:02]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489155772152460,
"parent_rev": "317e6094d7ae6ad7e4eafd17bbd4a80d61500c4c", "commit_rev":
"dfc151cf408ffc92bfdc1d40f06487f8a256bc0a"}

[commit-bot: I haz the power, 2017-03-10 15:26:54]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/bookmarks:bookmarks_arc_2 to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2737603007
Cr-Commit-Position: refs/heads/master@{#456064}
Committed:
https://chromium.googlesource.com/chromium/src/+/dfc151cf408ffc92bfdc1d40f064...
==========

[commit-bot: I haz the power, 2017-03-10 15:26:55]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/dfc151cf408ffc92bfdc1d40f064...

[baxley, 2017-03-10 16:55:09]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2738053008/ by baxley@chromium.org.

The reason for reverting is: EG bookmarks tests started failing after this CL.
Here is the first failure:
https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/25193.